git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Couder <chriscool@tuxfamily.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org, John Tapsell <johnflux@gmail.com>
Subject: Re: [PATCH 07/10] rev-list: call new "filter_skip" function
Date: Tue, 31 Mar 2009 08:45:23 +0200	[thread overview]
Message-ID: <200903310845.23674.chriscool@tuxfamily.org> (raw)
In-Reply-To: <alpine.DEB.1.00.0903300951460.7534@intel-tinevez-2-302>

Hi,

Le lundi 30 mars 2009, Johannes Schindelin a écrit :
> Hi,
>
> On Mon, 30 Mar 2009, Christian Couder wrote:
> > Le jeudi 26 mars 2009, Junio C Hamano a écrit :
> > >
> > > I've learned to suspect without reading a qsort() callback that does
> > > not derefence its arguments.  Is this doing the right thing?
> >
> > I think so.
>
> I suspect something much worse: you are trying to build a list of sha1s
> of commits that need to be skipped, later to look up every commit via
> binary search.
>
> But it has been proven a lot of times that using a hash set is superior
> to that approach, and even better: we already have the framework in place
> in the form of struct decorate.

I had a look, and "struct decorate" can be used to store objects, but I want 
to store only sha1s.

Regards,
Christian.

  reply	other threads:[~2009-03-31  6:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-26  4:55 [PATCH 07/10] rev-list: call new "filter_skip" function Christian Couder
2009-03-26  6:49 ` Junio C Hamano
2009-03-30  3:26   ` Christian Couder
2009-03-30  7:54     ` Johannes Schindelin
2009-03-31  6:45       ` Christian Couder [this message]
2009-03-31  9:23         ` Johannes Schindelin
2009-04-01  6:09           ` Christian Couder
2009-04-01 14:36             ` Johannes Schindelin
2009-04-02  4:23               ` Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200903310845.23674.chriscool@tuxfamily.org \
    --to=chriscool@tuxfamily.org \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johnflux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).