From: "Björn Steinbrink" <B.Steinbrink@gmx.de>
To: Jay Soffian <jaysoffian@gmail.com>
Cc: git@vger.kernel.org, Matthieu Moy <Matthieu.Moy@imag.fr>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/2] send-email: add tests for refactored prompting
Date: Tue, 31 Mar 2009 12:33:03 +0200 [thread overview]
Message-ID: <20090331103303.GD3307@atjola.homenet> (raw)
In-Reply-To: <1238290751-57461-2-git-send-email-jaysoffian@gmail.com>
On 2009.03.28 21:39:11 -0400, Jay Soffian wrote:
> +test_expect_success 'confirm detects EOF (auto causes failure)' '
> + CONFIRM=$(git config --get sendemail.confirm) &&
> + git config sendemail.confirm auto &&
> + GIT_SEND_EMAIL_NOTTY=1 \
> + test_must_fail git send-email \
> + --from="Example <nobody@example.com>" \
> + --to=nobody@example.com \
> + --smtp-server="$(pwd)/fake.sendmail" \
> + $patches < /dev/null
> + ret="$?"
> + git config sendemail.confirm ${CONFIRM:-never}
> + test $ret = "0"
> +'
> +
> +test_expect_success 'confirm doesnt loop forever' '
> + CONFIRM=$(git config --get sendemail.confirm) &&
> + git config sendemail.confirm auto &&
> + yes "bogus" | GIT_SEND_EMAIL_NOTTY=1 \
> + test_must_fail git send-email \
> + --from="Example <nobody@example.com>" \
> + --to=nobody@example.com \
> + --smtp-server="$(pwd)/fake.sendmail" \
> + $patches
> + ret="$?"
> + git config sendemail.confirm ${CONFIRM:-never}
> + test $ret = "0"
These two cause interactive prompts for me.
Björn
next prev parent reply other threads:[~2009-03-31 10:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-29 1:39 [PATCH 1/2] send-email: refactor and ensure prompting doesn't loop forever Jay Soffian
2009-03-29 1:39 ` [PATCH 2/2] send-email: add tests for refactored prompting Jay Soffian
2009-03-31 10:33 ` Björn Steinbrink [this message]
2009-03-31 13:58 ` Jay Soffian
2009-03-31 14:07 ` Jay Soffian
2009-03-31 14:19 ` Björn Steinbrink
2009-03-31 14:36 ` Jay Soffian
2009-03-29 1:48 ` [PATCH 1/2] send-email: refactor and ensure prompting doesn't loop forever Jay Soffian
2009-03-30 6:50 ` Junio C Hamano
2009-03-30 11:29 ` Matthieu Moy
2009-03-30 14:17 ` Jay Soffian
2009-03-30 14:18 ` Jay Soffian
2009-03-30 14:40 ` Matthieu Moy
2009-03-30 15:45 ` Jay Soffian
2009-03-30 16:04 ` Jay Soffian
2009-03-31 9:32 ` Matthieu Moy
2009-03-31 14:12 ` Jay Soffian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090331103303.GD3307@atjola.homenet \
--to=b.steinbrink@gmx.de \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jaysoffian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).