git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Magnus Bäck" <baeck@swipnet.se>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Heiko Voigt" <hvoigt@hvoigt.net>,
	"Björn Steinbrink" <B.Steinbrink@gmx.de>,
	"Johannes Sixt" <j6t@kdbg.org>,
	git@vger.kernel.org
Subject: Re: Implementing stat() with FindFirstFile()
Date: Tue, 31 Mar 2009 22:32:48 +0200	[thread overview]
Message-ID: <20090331203248.GE27249@jeeves.jpl.local> (raw)
In-Reply-To: <alpine.DEB.1.00.0903310128410.10279@pacific.mpi-cbg.de>

On Tuesday, March 31, 2009 at 01:29 CEST,
     Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

> On Tue, 31 Mar 2009, Heiko Voigt wrote:
> 
> > On Mon, Mar 30, 2009 at 07:11:18AM +0200, Björn Steinbrink wrote:
> >
> > > Not official documentation, but at least from some MS guy it seems: 
> > > http://www.osronline.com/showThread.cfm?link=73086 (last message).
> > > 
> > > Apparently, it was in NT3.x, but they document only what's actually 
> > > defined in the header.
> > 
> > How about runtime checking? You could do GetProcAddress(...) and if
> > you don't get it use the old behaviour. I mean if it really is
> > faster why not let Users of recent systems benefit from it.
> 
> While my first reaction was negative, I have to admit that thinking
> about it longer, it does seem to make a whole lot of sense.

If anything worries me it's forward compatibility should Microsoft
change the function signature. Backwards compatibility can always
be guaranteed by using GetProcAddress(). Again, I would be very
surprised but IF it could be quite fatal.

Anyway, we don't know for sure if it's faster or if it fixes the DST
problem of FindFirstFile(). I'll write some code to try it out.

-- 
Magnus Bäck
baeck@swipnet.se

  reply	other threads:[~2009-03-31 20:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-21 15:47 Implementing stat() with FindFirstFile() Magnus Bäck
2009-03-21 19:55 ` Johannes Sixt
2009-03-24 21:54   ` Magnus Bäck
2009-03-26  7:15     ` Johannes Sixt
2009-03-26 21:39       ` Magnus Bäck
2009-03-27  2:25         ` Johannes Schindelin
2009-03-29 22:48           ` Magnus Bäck
2009-03-30  0:52             ` Johannes Schindelin
2009-03-30  5:11               ` Björn Steinbrink
2009-03-30 22:07                 ` Heiko Voigt
2009-03-30 23:29                   ` Johannes Schindelin
2009-03-31 20:32                     ` Magnus Bäck [this message]
2009-03-31 20:49                       ` Johannes Schindelin
2009-04-01  9:28 ` Nazri Ramliy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090331203248.GE27249@jeeves.jpl.local \
    --to=baeck@swipnet.se \
    --cc=B.Steinbrink@gmx.de \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=hvoigt@hvoigt.net \
    --cc=j6t@kdbg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).