From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Alex Riesen <raa.lkml@gmail.com>, git@vger.kernel.org
Subject: Re: bsd group semantics
Date: Tue, 31 Mar 2009 18:25:42 -0400 [thread overview]
Message-ID: <20090331222540.GA25820@coredump.intra.peff.net> (raw)
In-Reply-To: <7vr60d4btl.fsf@gitster.siamese.dyndns.org>
On Tue, Mar 31, 2009 at 02:33:26PM -0700, Junio C Hamano wrote:
> > - # All directories must have 2770
> > - test -z "$(sed -n -e "/^drwxrws---/d" -e "/^d/p" actual)" &&
>
> Did you mean
>
> - # All directories must have 2770
> - test -z "$(sed -n -e "/^drwxrws---/d" -e "/^d/p" actual)" &&
> + # All directories must have either 2770 or 770
> + test -z "$(sed -n -e "/^drwxrw[sx]---/d" -e "/^d/p" actual)" &&
No, I meant what I said, but I was wrong. ;) I was thinking that bit
only tested for one thing, but it was actually testing for two. Sorry.
Can you fix it up when you apply, then?
-Peff
prev parent reply other threads:[~2009-03-31 22:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-31 11:26 bsd group semantics Jeff King
2009-03-31 15:55 ` Junio C Hamano
2009-03-31 16:08 ` Jeff King
2009-03-31 17:32 ` Junio C Hamano
2009-03-31 18:46 ` Jeff King
2009-03-31 20:26 ` Junio C Hamano
2009-03-31 20:36 ` Jeff King
2009-03-31 21:33 ` Junio C Hamano
2009-03-31 22:25 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090331222540.GA25820@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).