From: Finn Arne Gangstad <finnag@pvv.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, demerphq <demerphq@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] git remote update: New option --prune (-p)
Date: Thu, 2 Apr 2009 22:18:03 +0200 [thread overview]
Message-ID: <20090402201803.GA5397@pvv.org> (raw)
In-Reply-To: <7vab6zexq7.fsf@gitster.siamese.dyndns.org>
On Thu, Apr 02, 2009 at 11:06:56AM -0700, Junio C Hamano wrote:
> [...]
>
> I gave the patch an only cursory look, so I wouldn't comment on the
> implementation; two things I would look at in the code would be if it
> makes two connections to the remote to learn the same information (which
> would be bad)
How bad? git remote update execs "git fetch <remote>" to do the
fetching part, and after that the information is lost of course. It
might be possible to do a --prune option to fetch instead, and just
use that directly.
> and if it skips the pruning stage if the update stage failed
> (which would probably be a sane precaution).
Yes, this should be fixed.
- Finn Arne
next prev parent reply other threads:[~2009-04-02 20:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-02 12:38 [PATCH] git remote update: New option --prune (-p) Finn Arne Gangstad
2009-04-02 13:34 ` demerphq
2009-04-02 13:44 ` Jeff King
2009-04-02 14:17 ` demerphq
2009-04-02 14:31 ` Jeff King
2009-04-02 16:07 ` demerphq
2009-04-02 16:32 ` Jeff King
2009-04-02 19:05 ` demerphq
2009-04-02 18:06 ` Junio C Hamano
2009-04-02 20:18 ` Finn Arne Gangstad [this message]
2009-04-02 20:52 ` Junio C Hamano
2009-04-03 9:00 ` [PATCHv2 0/2] " Finn Arne Gangstad
2009-04-03 9:02 ` [PATCHv2 1/2] builtin-remote.c: Split out prune_remote as a separate function Finn Arne Gangstad
2009-04-03 9:03 ` [PATCHv2 2/2] git remote update: New option --prune Finn Arne Gangstad
2009-04-05 9:47 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090402201803.GA5397@pvv.org \
--to=finnag@pvv.org \
--cc=demerphq@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).