From: David Aguilar <davvid@gmail.com>
To: Brian Gernhardt <benji@silverinsanity.com>
Cc: gitster@pobox.com, markus.heidelberg@web.de,
charles@hashpling.org, git@vger.kernel.org
Subject: Re: [PATCH v2] mergetool--lib: add new merge tool TortoiseMerge
Date: Mon, 6 Apr 2009 02:27:36 -0700 [thread overview]
Message-ID: <20090406092736.GA16408@gmail.com> (raw)
In-Reply-To: <DB42161D-8B55-4739-B418-D286B280EFF8@silverinsanity.com>
On 0, Brian Gernhardt <benji@silverinsanity.com> wrote:
>
> On Apr 5, 2009, at 12:00 AM, David Aguilar wrote:
>
>> valid_tool () {
>> case "$1" in
>> <lots-of-stuff>)
>> if test "$1" = "kompare" && ! diff_mode; then
>> return 1
>> fi
>> + if test "$1" = "tortoisemerge" && ! merge_mode; then
>> + return 1
>> + fi
>> ;; # happy
>> *)
>> if test -z "$(get_merge_tool_cmd "$1")"; then
>
> Why is `case "$1"` being followed by two `if test "$1" =`s?
> Wouldn't it be simpler to have separate case arms for them?
> Especially with how long that list is getting...
>
> ~~ Brian
It would. It wasn't until after the rewrite that I remembered
this email... oh well [PATCH v2 14/14] it is
--
David
prev parent reply other threads:[~2009-04-06 9:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-05 4:00 [PATCH v2] mergetool--lib: add new merge tool TortoiseMerge David Aguilar
2009-04-05 5:10 ` Brian Gernhardt
2009-04-06 9:27 ` David Aguilar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090406092736.GA16408@gmail.com \
--to=davvid@gmail.com \
--cc=benji@silverinsanity.com \
--cc=charles@hashpling.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=markus.heidelberg@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).