From: Finn Arne Gangstad <finnag@pvv.org>
To: Matthieu Moy <Matthieu.Moy@imag.fr>
Cc: gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH v2] git-pull.sh: better warning message for "git pull" on detached head.
Date: Tue, 7 Apr 2009 12:41:46 +0200 [thread overview]
Message-ID: <20090407104145.GA22658@pvv.org> (raw)
In-Reply-To: <1239098181-10360-1-git-send-email-Matthieu.Moy@imag.fr>
On Tue, Apr 07, 2009 at 11:56:21AM +0200, Matthieu Moy wrote:
> Otherwise, git complains about not finding a branch to pull from in
> 'branch..merge', which is hardly understandable. While we're there,
> reword the sentences slightly.
> [...]
> + if [ -z "$curr_branch" ]; then
> + echo "You asked me to pull without telling me which branch you want"
> + echo "to merge with, and you are on a detached HEAD, so I cannot"
> [...]
In this case why can't we just do
echo "You are currently not on any branch."
or
echo "git pull cannot be run without arguments unless you are on a branch."
And possibly also something like this:
echo "Usage: git pull <repository> <refspec>."
echo " See git-pull(1) for details."
echo
If you need all the verbosity this error otherwise gives, "detached
HEAD" is probably going to be confusing?
- Finn Arne
next prev parent reply other threads:[~2009-04-07 10:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-06 21:14 [PATCH] git-pull.sh: better warning message for "git pull" on detached head Matthieu Moy
2009-04-07 9:24 ` Mike Ralphson
2009-04-07 9:56 ` [PATCH v2] " Matthieu Moy
2009-04-07 10:41 ` Finn Arne Gangstad [this message]
2009-04-07 11:36 ` Matthieu Moy
2009-04-08 0:43 ` Junio C Hamano
2009-04-08 7:24 ` [PATCH] " Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090407104145.GA22658@pvv.org \
--to=finnag@pvv.org \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).