Re: [PATCH 2/3] rev-list: remove last static vars used in "show_commit"

[Christian Couder <chriscool@tuxfamily.org>]

Le mercredi 8 avril 2009, Paolo Bonzini a écrit :
> >  	struct rev_info revs;
> > +	struct rev_list_info info;
> >  	int reaches = 0, all = 0;
> >
> > +	memset(&info, 0, sizeof(info));
> > +	info.revs = &revs;
>
> Would it make sense to embed the struct rev_info entirely in the new
> struct, without going through a pointer?

Perhaps, I will have a look.

The downside is that the struct rev_info may be initialized twice if we 
still use "memset(&info, 0, sizeof(info))" as it is also initialized 
in "init_revisions".

Thanks,
Christian.