From: Mike Hommey <mh@glandium.org>
To: Riku Voipio <riku.voipio@iki.fi>
Cc: git@vger.kernel.org
Subject: Re: bug: git-http-push fails to validate email address in LOCK request
Date: Thu, 9 Apr 2009 14:02:06 +0200 [thread overview]
Message-ID: <20090409120205.GA29046@glandium.org> (raw)
In-Reply-To: <20090409111944.GA22297@kos.to>
On Thu, Apr 09, 2009 at 02:19:44PM +0300, Riku Voipio <riku.voipio@iki.fi> wrote:
> from http-push.c, we see that the lock request is:
>
> #define LOCK_REQUEST "<?xml version=\"1.0\" encoding=\"utf-8\" ?>\n<D:lockinfo xmlns:D=\"DAV:\">\n<D:lockscope><D:exclusive/></D:lockscope>\n<D:locktype><D:write/></D:locktype>\n<D:owner>\n<D:href>mailto:%s</D:href>\n</D:owner>\n</D:lockinfo>"
>
> So there is exactly one variable being set. Turns out the email
> address in .gitconfig was set to '<riku.voipio@iki.fi>'. Yes,
> a user error. This was copied from $EMAIL env variable, where
> using strings such as 'foo bar <foo.bar@corp.com>' have been
> a norm forever.
That's the problem with generating XML by concatenating strings without
checks :(
Mike
next prev parent reply other threads:[~2009-04-09 12:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-09 11:19 bug: git-http-push fails to validate email address in LOCK request Riku Voipio
2009-04-09 12:02 ` Mike Hommey [this message]
2009-04-09 22:23 ` [PATCH] Replace ",<,>,& with their respective XML entities in DAV requests Mike Hommey
2009-04-09 22:25 ` [PATCH v2] " Mike Hommey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090409120205.GA29046@glandium.org \
--to=mh@glandium.org \
--cc=git@vger.kernel.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).