Re: [PATCH] process_{tree,blob}: Remove useless xstrdup calls

["Björn Steinbrink" <B.Steinbrink@gmx.de>]

On 2009.04.11 11:22:09 -0700, Linus Torvalds wrote:
> 
> 
> On Sat, 11 Apr 2009, Linus Torvalds wrote:
> > On Sat, 11 Apr 2009, Björn Steinbrink wrote:
> > 
> > > And again, the new pack is slightly worse than the old one
> > >  (window=250, --depth=250).
> > > Old: 240238406
> > > New: 240280452
> > > 
> > > But again, it's negligible.
> > 
> > Well, it's sad that it's consistently a bit worse, even if we're talking 
> > just small small fractions of a percent (looks like 0.02% bigger ;). 
> 
> Oh, just wondering: that 0.02% is negligible, but did you use "-f" (or 
> --no-reuse-delta if you're testing with 'git pack-objects') to see that 
> it's actually re-computing the deltas?
> 
> The 0.02% difference might be just because of differences in pack layout. 
> If you force all deltas to be recomputed, maybe the difference is much 
> bigger?

Yep, that was "git repack -adf --window=250 --depth=250".

Björn