Re: [PATCH/RESEND] gitweb: Fix snapshots requested via PATH_INFO

["Holger Weiß" <holger@zedat.fu-berlin.de>]

* Giuseppe Bilotta <giuseppe.bilotta@gmail.com> [2009-04-15 11:33]:
> On Wed, Apr 15, 2009 at 8:40 AM, Junio C Hamano <gitster@pobox.com> wrote:
> > Holger Weiß <holger@zedat.fu-berlin.de> writes:
> >> Fix the detection of the requested snapshot format, which failed for
> >> PATH_INFO URLs since the references to the hashes which describe the
> >> supported snapshot formats weren't dereferenced appropriately.
> >>
> >> Signed-off-by: Holger Weiß <holger@zedat.fu-berlin.de>
> >> ---
> >> I guess this one got lost.  Without this patch, snapshots won't work if
> >> Gitweb is configured to generate PATH_INFO URLs.  (Original Message-ID:
> >> <20090331161636.GV30233737@CIS.FU-Berlin.DE>).
> >
> > The patch looks obviously correct; "our %known_snapshort_formats" maps a
> > name to a hashref, but the current code makes a nonsense assignment,
> > essentialy doing ($fmt, %opt) = ($name, $hashref), but what would I
> > know...  I am not using gitweb actively.
> 
> My gitweb over at http://git.oblomov.eu/ supports snapshots with
> PATH_INFO just fine even without the need for this patch.

Really?  If I try to download a snapshot from your site, I get an empty
tarball (and the server appends an additional ".tar.gz" suffix to the
filename within the "Content-disposition" header).  For example:

$ wget -q -O - http://git.oblomov.eu/git/snapshot/v1.6.2.3.tar.gz | gzip -d | tar -t | wc -l
0

That's the bug which is fixed by my patch.

Holger