From: "Shawn O. Pearce" <spearce@spearce.org>
To: Constantine Plotnikov <constantine.plotnikov@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [JGIT PATCH 1/3] Changed Transport class hierarchy basing on underlying transport
Date: Fri, 17 Apr 2009 07:58:46 -0700 [thread overview]
Message-ID: <20090417145846.GP23604@spearce.org> (raw)
In-Reply-To: <85647ef50904160703y3a416294k54f21b50f6006040@mail.gmail.com>
Constantine Plotnikov <constantine.plotnikov@gmail.com> wrote:
> Instead of WalkTransport and PackTransport the transports
> are now using SshTransport, TcpTransport, and HttpTransport,
> indicating the type of basic underlying protocol is dealt
> with. This lays groundwork for supplying transport specific
> properties in the future. The WalkTransport and PackTransport
> are now marker interfaces.
The entire patch looks fine. Except its corrupted by line wrapping
by your MUA. Can you please resend without using format-flawed ?
:-)
> .../spearce/jgit/transport/BasePackConnection.java | 8 +-
> .../jgit/transport/BasePackFetchConnection.java | 4 +-
> .../jgit/transport/BasePackPushConnection.java | 4 +-
> .../jgit/transport/BundleFetchConnection.java | 247 ++++++++++++++++++++
> .../org/spearce/jgit/transport/HttpTransport.java | 62 +++++
> .../org/spearce/jgit/transport/PackTransport.java | 12 +-
> .../org/spearce/jgit/transport/SshTransport.java | 62 +++++
> .../org/spearce/jgit/transport/TcpTransport.java | 62 +++++
> .../spearce/jgit/transport/TransportAmazonS3.java | 2 +-
> .../spearce/jgit/transport/TransportBundle.java | 227 +-----------------
> .../jgit/transport/TransportBundleFile.java | 16 ++-
> .../jgit/transport/TransportBundleStream.java | 11 +-
> .../spearce/jgit/transport/TransportGitAnon.java | 2 +-
> .../spearce/jgit/transport/TransportGitSsh.java | 2 +-
> .../org/spearce/jgit/transport/TransportHttp.java | 9 +-
> .../org/spearce/jgit/transport/TransportLocal.java | 2 +-
> .../org/spearce/jgit/transport/TransportSftp.java | 2 +-
> .../jgit/transport/WalkFetchConnection.java | 3 +-
> .../spearce/jgit/transport/WalkPushConnection.java | 5 +-
> .../org/spearce/jgit/transport/WalkTransport.java | 21 +--
> 20 files changed, 497 insertions(+), 266 deletions(-)
> create mode 100644
> org.spearce.jgit/src/org/spearce/jgit/transport/BundleFetchConnection.java
> create mode 100644
> org.spearce.jgit/src/org/spearce/jgit/transport/HttpTransport.java
> create mode 100644
> org.spearce.jgit/src/org/spearce/jgit/transport/SshTransport.java
> create mode 100644
> org.spearce.jgit/src/org/spearce/jgit/transport/TcpTransport.java
--
Shawn.
next prev parent reply other threads:[~2009-04-17 15:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 14:03 [JGIT PATCH 1/3] Changed Transport class hierarchy basing on underlying transport Constantine Plotnikov
2009-04-17 14:58 ` Shawn O. Pearce [this message]
[not found] ` <85647ef50904170830iccabee9n5a7a6cdb283654f9@mail.gmail.com>
2009-04-17 15:40 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090417145846.GP23604@spearce.org \
--to=spearce@spearce.org \
--cc=constantine.plotnikov@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).