git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Constantine Plotnikov <constantine.plotnikov@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [JGIT PATCH 3/3] Extracted AWT-independent superclass from DefaultSshSessionFactory
Date: Fri, 17 Apr 2009 08:16:45 -0700	[thread overview]
Message-ID: <20090417151645.GQ23604@spearce.org> (raw)
In-Reply-To: <85647ef50904160711w6fbcfcedk2b9a9e1740a4ddd3@mail.gmail.com>

Constantine Plotnikov <constantine.plotnikov@gmail.com> wrote:
> The part of DefaultSshSessionFactory that does not depend on
> AWT was refactored to the super class SshConfigSessionFactory.
> The parts of DefaultSshSessionFactory that were used only by
> the OpenSshConfig class were moved to that class.
> 
> Signed-off-by: Constantine Plotnikov <constantine.plotnikov@gmail.com>

Thanks. I applied this, but with a couple of style nitpicks corrected.

> --- a/org.spearce.jgit/src/org/spearce/jgit/transport/OpenSshConfig.java
> +++ b/org.spearce.jgit/src/org/spearce/jgit/transport/OpenSshConfig.java
> @@ -95,6 +97,9 @@ public static OpenSshConfig get() {
>  	/** Cached entries read out of the configuration file. */
>  	private Map<String, Host> hosts;
> 
> +	/** IANA assigned port number for SSH. */
> +	static final int SSH_PORT = 22;
> +

Static constants should be at the top of the class, not after the
instance members.

-- 
Shawn.

      reply	other threads:[~2009-04-17 15:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-16 14:11 [JGIT PATCH 3/3] Extracted AWT-independent superclass from DefaultSshSessionFactory Constantine Plotnikov
2009-04-17 15:16 ` Shawn O. Pearce [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090417151645.GQ23604@spearce.org \
    --to=spearce@spearce.org \
    --cc=constantine.plotnikov@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).