From: "Shawn O. Pearce" <spearce@spearce.org>
To: Mike Hommey <mh@glandium.org>
Cc: Dmitry Potapov <dpotapov@gmail.com>,
git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Allow git-shell to be used as a ssh forced-command
Date: Fri, 17 Apr 2009 15:41:04 -0700 [thread overview]
Message-ID: <20090417224104.GT23604@spearce.org> (raw)
In-Reply-To: <20090417223649.GA1881@glandium.org>
Mike Hommey <mh@glandium.org> wrote:
> On Sat, Apr 18, 2009 at 01:00:35AM +0400, Dmitry Potapov wrote:
> > Besides, you made SSH_ORIGINAL_COMMAND to take precedent over explicitly
> > specified parameters given to git-shell. Maybe it should be the other
> > way around?
>
> If SSH_ORIGINAL_COMMAND is set, which means forced-commands are in use,
> I don't see why other parameters should be more important.
Gitosis runs by forced-command, and invokes git-shell to get to
the real requested git command. I'm not sure if it unsets the
SSH_ORIGINAL_COMMAND environment variable before launching the
git-shell...
But, in git, command line arguments override environment variables,
which in turn override config files, which override any defaults
that may be guessed from the host. So Dimtry is asking that you
follow that same convention.
--
Shawn.
next prev parent reply other threads:[~2009-04-17 22:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 21:10 [PATCH] Allow git-shell to be used as a ssh forced-command Mike Hommey
2009-04-17 16:24 ` Dmitry Potapov
2009-04-17 19:49 ` Mike Hommey
2009-04-17 21:00 ` Dmitry Potapov
2009-04-17 22:36 ` Mike Hommey
2009-04-17 22:41 ` Shawn O. Pearce [this message]
2009-04-17 23:44 ` Mike Hommey
2009-04-18 7:46 ` Matthieu Moy
2009-04-17 23:40 ` Junio C Hamano
2009-04-17 23:48 ` Tommi Virtanen
2009-04-18 1:24 ` Junio C Hamano
2009-04-18 6:31 ` Mike Hommey
2009-04-21 5:43 ` [PATCH v2] " Mike Hommey
2009-04-21 8:05 ` Dmitry Potapov
2009-04-21 9:46 ` Eygene Ryabinkin
2009-04-21 8:13 ` Junio C Hamano
2009-04-21 9:09 ` Mike Hommey
2009-04-21 11:16 ` Dmitry Potapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090417224104.GT23604@spearce.org \
--to=spearce@spearce.org \
--cc=dpotapov@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mh@glandium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).