Re: [PATCH] Allow git-shell to be used as a ssh forced-command

[Mike Hommey <mh@glandium.org>]

On Fri, Apr 17, 2009 at 03:41:04PM -0700, Shawn O. Pearce wrote:
> Mike Hommey <mh@glandium.org> wrote:
> > On Sat, Apr 18, 2009 at 01:00:35AM +0400, Dmitry Potapov wrote:
> > > Besides, you made SSH_ORIGINAL_COMMAND to take precedent over explicitly
> > > specified parameters given to git-shell. Maybe it should be the other
> > > way around?
> > 
> > If SSH_ORIGINAL_COMMAND is set, which means forced-commands are in use,
> > I don't see why other parameters should be more important.
> 
> Gitosis runs by forced-command, and invokes git-shell to get to
> the real requested git command.  I'm not sure if it unsets the
> SSH_ORIGINAL_COMMAND environment variable before launching the
> git-shell...
> 
> But, in git, command line arguments override environment variables,
> which in turn override config files, which override any defaults
> that may be guessed from the host.  So Dimtry is asking that you
> follow that same convention.

Except SSH_ORIGINAL_COMMAND is not a traditional environment variable
like GIT_USER_EMAIL or such. SSH_ORIGINAL_COMMAND is the only way to
know from a ssh forced-command what the remote wanted to call
originally. Setting a forced-command with options after git-shell, which
would have to be "-c something" or "cvs server", is pointless, because
you don't need it and should put that "something" as forced-command directly.

However, the patch in its current form will definitely break gitosis if
it doesn't unset SSH_ORIGINAL_COMMAND.

Mike