From: Tommi Virtanen <tv@eagain.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Mike Hommey <mh@glandium.org>, git@vger.kernel.org
Subject: Re: [PATCH] Allow git-shell to be used as a ssh forced-command
Date: Fri, 17 Apr 2009 16:48:59 -0700 [thread overview]
Message-ID: <20090417234859.GY898@eagain.net> (raw)
In-Reply-To: <7v63h24znd.fsf@gitster.siamese.dyndns.org>
On Fri, Apr 17, 2009 at 04:40:54PM -0700, Junio C Hamano wrote:
> How does this interact with a typical gitosis installation? I think it
> extracts bits from the ORIGINAL_COMMAND and formulates a sanitized command
> line and then passes it to git-shell but I do not think it removes the
> variable from the environment.
Yup, not sanitizing. I could make that change easily, if you want, but
there's plenty of installations out there already.
I'd say add a git-shell flag that enables any magic behavior, don't
just magically work differently based on that environment variable.
Sometimes that is set for reasons that are not related to what you're
actually running in the end; e.g. "chroot /foo exec-whatever-i-gave-you".
--
:(){ :|:&};:
next prev parent reply other threads:[~2009-04-18 0:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 21:10 [PATCH] Allow git-shell to be used as a ssh forced-command Mike Hommey
2009-04-17 16:24 ` Dmitry Potapov
2009-04-17 19:49 ` Mike Hommey
2009-04-17 21:00 ` Dmitry Potapov
2009-04-17 22:36 ` Mike Hommey
2009-04-17 22:41 ` Shawn O. Pearce
2009-04-17 23:44 ` Mike Hommey
2009-04-18 7:46 ` Matthieu Moy
2009-04-17 23:40 ` Junio C Hamano
2009-04-17 23:48 ` Tommi Virtanen [this message]
2009-04-18 1:24 ` Junio C Hamano
2009-04-18 6:31 ` Mike Hommey
2009-04-21 5:43 ` [PATCH v2] " Mike Hommey
2009-04-21 8:05 ` Dmitry Potapov
2009-04-21 9:46 ` Eygene Ryabinkin
2009-04-21 8:13 ` Junio C Hamano
2009-04-21 9:09 ` Mike Hommey
2009-04-21 11:16 ` Dmitry Potapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090417234859.GY898@eagain.net \
--to=tv@eagain.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mh@glandium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).