From: Christian Couder <chriscool@tuxfamily.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: [PATCH 2/2] rev-list: remove stringed output flag from "show_bisect_vars"
Date: Tue, 21 Apr 2009 07:54:10 +0200 [thread overview]
Message-ID: <20090421055411.4006.28030.chriscool@tuxfamily.org> (raw)
Because it was used only by "git bisect--helper --next-vars" but
the "--next-vars" option has been removed.
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
bisect.h | 1 -
builtin-rev-list.c | 32 +++++++++++++++-----------------
2 files changed, 15 insertions(+), 18 deletions(-)
diff --git a/bisect.h b/bisect.h
index 908e362..0b5d122 100644
--- a/bisect.h
+++ b/bisect.h
@@ -16,7 +16,6 @@ extern void print_commit_list(struct commit_list *list,
/* bisect_show_flags flags in struct rev_list_info */
#define BISECT_SHOW_ALL (1<<0)
#define BISECT_SHOW_TRIED (1<<1)
-#define BISECT_SHOW_STRINGED (1<<2)
struct rev_list_info {
struct rev_info *revs;
diff --git a/builtin-rev-list.c b/builtin-rev-list.c
index 35f88ca..31ea5f4 100644
--- a/builtin-rev-list.c
+++ b/builtin-rev-list.c
@@ -235,26 +235,26 @@ void print_commit_list(struct commit_list *list,
}
}
-static void show_tried_revs(struct commit_list *tried, int stringed)
+static void show_tried_revs(struct commit_list *tried)
{
printf("bisect_tried='");
print_commit_list(tried, "%s|", "%s");
- printf(stringed ? "' &&\n" : "'\n");
+ printf("'\n");
}
-static void print_var_str(const char *var, const char *val, int stringed)
+static void print_var_str(const char *var, const char *val)
{
- printf("%s='%s'%s\n", var, val, stringed ? " &&" : "");
+ printf("%s='%s'\n", var, val);
}
-static void print_var_int(const char *var, int val, int stringed)
+static void print_var_int(const char *var, int val)
{
- printf("%s=%d%s\n", var, val, stringed ? " &&" : "");
+ printf("%s=%d\n", var, val);
}
int show_bisect_vars(struct rev_list_info *info, int reaches, int all)
{
- int cnt, stringed, flags = info->bisect_show_flags;
+ int cnt, flags = info->bisect_show_flags;
char hex[41] = "";
struct commit_list *tried;
struct rev_info *revs = info->revs;
@@ -285,17 +285,15 @@ int show_bisect_vars(struct rev_list_info *info, int reaches, int all)
printf("------\n");
}
- stringed = flags & BISECT_SHOW_STRINGED;
-
if (flags & BISECT_SHOW_TRIED)
- show_tried_revs(tried, stringed);
-
- print_var_str("bisect_rev", hex, stringed);
- print_var_int("bisect_nr", cnt - 1, stringed);
- print_var_int("bisect_good", all - reaches - 1, stringed);
- print_var_int("bisect_bad", reaches - 1, stringed);
- print_var_int("bisect_all", all, stringed);
- print_var_int("bisect_steps", estimate_bisect_steps(all), 0);
+ show_tried_revs(tried);
+
+ print_var_str("bisect_rev", hex);
+ print_var_int("bisect_nr", cnt - 1);
+ print_var_int("bisect_good", all - reaches - 1);
+ print_var_int("bisect_bad", reaches - 1);
+ print_var_int("bisect_all", all);
+ print_var_int("bisect_steps", estimate_bisect_steps(all));
return 0;
}
--
1.6.2.2.537.g3b83b
reply other threads:[~2009-04-21 5:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090421055411.4006.28030.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).