From: Allan Caffee <allan.caffee@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [RFC/PATCH v2] graph API: Use horizontal lines for more compact graphs
Date: Wed, 22 Apr 2009 17:28:12 -0400 [thread overview]
Message-ID: <20090422212812.GA30830@linux.vnet> (raw)
In-Reply-To: <20090421124701.GA25982@linux.vnet>
On Tue, 21 Apr 2009, Allan Caffee wrote:
> Use horizontal lines instead of long diagonal during graph collapsing
> and precommit for more compact and legible graphs.
Please replace this message with:
----8<----------------
Use horizontal lines instead of long diagonal lines during the
collapsing state of graph rendering. For example what used to be:
| | | | |
| | | |/
| | |/|
| |/| |
|/| | |
| | | |
is now
| | | | |
| |_|_|/
|/| | |
| | | |
This results in more compact and legible graphs.
---->8----------------
Notice that I dropped out the part about precommits. Originally I
intended to utilize horizontal lines in pre_commit_line's as well. But
partway through I decided to just do collapsing_line's for now since (a)
collapsing_line edges tend to extend much longer and (b)
pre_commit_line's are less common since they only occur when there is a
merge with at least three parents, and (c) the change for
pre_commit_lines is liable to be more complicated and error-prone.
next prev parent reply other threads:[~2009-04-22 21:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-21 0:40 [RFC/PATCH] graph API: Use horizontal lines for more compact graphs Allan Caffee
2009-04-21 0:56 ` Johannes Schindelin
2009-04-21 2:23 ` Allan Caffee
2009-04-21 8:13 ` Johannes Schindelin
2009-04-21 12:47 ` [RFC/PATCH v2] " Allan Caffee
2009-04-21 13:17 ` Johannes Schindelin
2009-04-21 13:36 ` Bug in colored "log --graph" implementation Teemu Likonen
2009-04-21 18:34 ` [PATCH] graph API: fix extra space during pre_commit_line state Allan Caffee
2009-04-22 3:25 ` Teemu Likonen
2009-04-22 19:38 ` Allan Caffee
2009-04-22 19:52 ` [PATCH 2/3] " Allan Caffee
2009-04-22 21:27 ` [PATCH 1/3] t4202-log: extend test coverage of graphing Allan Caffee
2009-04-22 21:27 ` [PATCH 2/3] graph API: fix extra space during pre_commit_line state Allan Caffee
2009-04-22 21:27 ` [PATCH 3/3] graph API: fix a bug in the rendering of octopus merges Allan Caffee
2009-04-22 21:28 ` Allan Caffee [this message]
2009-04-27 15:43 ` [PATCH v2 (resend)] graph API: Use horizontal lines for more compact graphs Allan Caffee
2009-04-27 16:35 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090422212812.GA30830@linux.vnet \
--to=allan.caffee@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).