From: Jeff King <peff@peff.net>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] remote.c: silently tolerate single-level keys like remote.default
Date: Thu, 23 Apr 2009 16:01:37 -0400 [thread overview]
Message-ID: <20090423200136.GA3056@coredump.intra.peff.net> (raw)
In-Reply-To: <200904232037.27095.j6t@kdbg.org>
On Thu, Apr 23, 2009 at 08:37:26PM +0200, Johannes Sixt wrote:
> > + warn("Config with no key for remote %s", name);
> > + return 0;
>
> I don't like this. This would warn in a number of situations where it's not
> obvious that remotes are involved, for example in 'git status'.
Ah, I didn't think of that (I didn't really look too closely into the
affected code, and you obviously have). So let me withdraw my comment.
-Peff
next prev parent reply other threads:[~2009-04-23 20:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 13:49 [PATCH 1/2] remote.c: silently tolerate single-level keys like remote.default Johannes Sixt
2009-04-23 13:49 ` [PATCH 2/2] builtin-help: silently tolerate unknown keys Johannes Sixt
2009-04-23 16:40 ` [PATCH 1/2] remote.c: silently tolerate single-level keys like remote.default Jeff King
2009-04-23 18:37 ` Johannes Sixt
2009-04-23 20:01 ` Jeff King [this message]
2009-04-24 16:19 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090423200136.GA3056@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).