git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Robin Rosenberg <robin.rosenberg@dewire.com>
To: Alex Blewitt <alex@bandlem.com>
Cc: Francis Galiegue <fge@one2team.com>,
	git@vger.kernel.org, spearce@spearce.org
Subject: Re: [EGit PATCH] IgnoreAction to add to .gitignore files
Date: Thu, 23 Apr 2009 21:19:36 +0200	[thread overview]
Message-ID: <200904232119.36707.robin.rosenberg@dewire.com> (raw)
In-Reply-To: <0A94BEDB-37A1-44D2-BE54-D05F0C3124EE@bandlem.com>

torsdag 23 april 2009 14:32:46 skrev Alex Blewitt <alex@bandlem.com>:
> Actually, that's pretty much exactly the format that Eclipse users  
> will be expecting.
> 
> CVS: Add to .cvsignore
> SVN: Add to svn:ignore
> 
> I suggest that we go with that style of format for the menu items, in  
> order to achieve consistency with the way that the other team  
> providers work.

Ouch, top posting....

Anyway, I agree  with Alex. My motivation is that there are more
than one way to specify ignore. There's .gitignore, .git/info/excludedes
and the Team ignore settings themselves. This option specifically
messes with .gitignore. 

-- robin

> Note also that the tooltip is usually much shorter than that ... it's  
> not a full help description, it explains what it does.
> 
> Alex
> 
> On 23 Apr 2009, at 13:27, Francis Galiegue wrote:
> 
> > Le jeudi 23 avril 2009, Alex Blewitt a écrit :
> >> diff --git a/org.spearce.egit.ui/plugin.properties
> > b/org.spearce.egit.ui/plugin.properties
> >> index 523a959..be3b40c 100644
> >> --- a/org.spearce.egit.ui/plugin.properties
> >> +++ b/org.spearce.egit.ui/plugin.properties
> >> @@ -52,10 +52,12 @@ FetchAction_tooltip=Fetch from another repository
> >> PushAction_label=&Push To...
> >> PushAction_tooltip=Push to another repository
> >>
> >> +IgnoreAction_label=Add to .git&ignore...
> >> +IgnoreAction_tooltip=Ignore the selected resources
> >> +
> >> GitActions_label=Git
> >> GitMenu_label=&Git
> >>
> >
> > The label and tooltip are too "git-specific", IMHO. I'd rather see:
> >
> > IgnoreAction_label=&Ignore file(s) for commits...
> > IgnoreAction_tooltip=The selected file(s) will not be included by  
> > default in
> > your commits. However, you may force the include of these files in a  
> > commit
> > by explicitly adding them via "Team->Add" [or whatever the label is].
> > \n\nSelecting files to ignore by this mechanism will automatically  
> > add one or
> > more files named .gitignore in your next commit.
> >
> > -- 
> > Francis Galiegue
> > ONE2TEAM
> > Ingénieur système
> > Mob : +33 (0) 683 877 875
> > Tel : +33 (0) 178 945 552
> > fge@one2team.com
> > 40 avenue Raymond Poincaré
> > 75116 Paris
> 
> 

  reply	other threads:[~2009-04-23 19:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-23 11:50 [EGit PATCH] IgnoreAction to add to .gitignore files Alex Blewitt
2009-04-23 12:27 ` Francis Galiegue
2009-04-23 12:32   ` Alex Blewitt
2009-04-23 19:19     ` Robin Rosenberg [this message]
2009-04-23 20:17       ` Ferry Huberts (Pelagic)
2009-04-23 20:26         ` Robin Rosenberg
2009-04-23 20:36           ` Alex Blewitt
2009-04-23 20:48             ` Ferry Huberts (Pelagic)
2009-04-23 21:09             ` Robin Rosenberg
2009-04-23 21:12               ` Alex Blewitt
2009-04-23 23:08                 ` Robin Rosenberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200904232119.36707.robin.rosenberg@dewire.com \
    --to=robin.rosenberg@dewire.com \
    --cc=alex@bandlem.com \
    --cc=fge@one2team.com \
    --cc=git@vger.kernel.org \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).