git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/2] Documentation: replace SHA1 by SHA-1
Date: Fri, 24 Apr 2009 17:30:56 -0400	[thread overview]
Message-ID: <20090424213056.GC14435@coredump.intra.peff.net> (raw)
In-Reply-To: <1240584575-5702-3-git-send-email-git@drmicha.warpmail.net>

On Fri, Apr 24, 2009 at 04:49:35PM +0200, Michael J Gruber wrote:

> --- a/Documentation/git-pack-objects.txt
> +++ b/Documentation/git-pack-objects.txt
> @@ -47,7 +47,7 @@ base-name::
>  	Write into a pair of files (.pack and .idx), using
>  	<base-name> to determine the name of the created file.
>  	When this option is used, the two files are written in
> -	<base-name>-<SHA1>.{pack,idx} files.  <SHA1> is a hash
> +	<base-name>-<SHA-1>.{pack,idx} files.  <SHA-1> is a hash
>  	of the sorted object names to make the resulting filename
>  	based on the pack content, and written to the standard
>  	output of the command.

Same complaint as the last patch. The extra hyphen is really
distracting, as it is in the midst of an already hyphenated filename.
Interestingly, I don't find <base-name> as bad. I think it is because
the single numeric character with the punctuation is just hard on the
eyes.

-Peff

  reply	other threads:[~2009-04-24 21:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-24 14:49 [PATCH 0/2] Unify use of [sha,SHA][,-]1 Michael J Gruber
2009-04-24 14:49 ` [PATCH 1/2] Documentation: replace sha1 by SHA-1 Michael J Gruber
2009-04-24 14:49   ` [PATCH 2/2] Documentation: replace SHA1 " Michael J Gruber
2009-04-24 21:30     ` Jeff King [this message]
2009-04-24 15:18   ` [PATCH 1/2] Documentation: replace sha1 " Johannes Sixt
2009-04-24 15:23     ` Wincent Colaiuta
2009-04-24 15:33       ` Michael J Gruber
2009-04-24 15:30     ` Michael J Gruber
2009-04-24 21:28   ` Jeff King
2009-04-24 22:38     ` Junio C Hamano
2009-04-25 10:47       ` Felipe Contreras
2009-04-25 12:13   ` Dmitry Potapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090424213056.GC14435@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).