From: "Björn Steinbrink" <B.Steinbrink@gmx.de>
To: Michael Witten <mfwitten@gmail.com>
Cc: Daniel Barkalow <barkalow@iabervon.org>,
Jeff King <peff@peff.net>, Johan Herland <johan@herland.net>,
git@vger.kernel.org, David Abrahams <dave@boostpro.com>,
"J. Bruce Fields" <bfields@fieldses.org>
Subject: Re: [doc] User Manual Suggestion
Date: Mon, 27 Apr 2009 02:00:07 +0200 [thread overview]
Message-ID: <20090427000007.GE12338@atjola.homenet> (raw)
In-Reply-To: <b4087cc50904241629u76454b1chc6e84e95066a9100@mail.gmail.com>
On 2009.04.24 18:29:22 -0500, Michael Witten wrote:
> On Fri, Apr 24, 2009 at 18:21, Daniel Barkalow <barkalow@iabervon.org> wrote:
> > "git blame 1a2b3c:Makefile" worked despite this technically being
> > incoherent.
>
> It seems to work on my end, and it's perfectly coherent if you
> consider git-blame to be overloaded to handle both pointers and
> addresses (or references and object names, if you prefer).
Fails for me. And it's technically incoherent in that it makes no sense
to use blame with a blob object. 1a2b3c:Makefile identifies "just" a
blob object. And that has no parents and no history, just contents. Only
the commit objects have the references that connect them to form a
history.
For example, you could have a history like this:
A---B---C---D---E
And a file "foo" that has the same contents for A and E. Then "A:foo"
and "E:foo" lead to the same blob object, and you can't uniquely go from
that blob object to any commit object. So technically, you can't tell if
"git blame E:foo" means "git blame E foo" or "git blame A foo" (and you
can add a bunch of complexity by having, for example, a second file
with a different name that had the same content at some point).
To make that coherent, you must change the definition of the
<tree-ish>:<path> syntax so that the context in which the path is
resolved is kept, it must no longer just identify an object, but
something more complex.
Björn
next prev parent reply other threads:[~2009-04-27 0:02 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-22 19:38 [doc] User Manual Suggestion David Abrahams
2009-04-23 17:57 ` J. Bruce Fields
2009-04-23 18:37 ` Michael Witten
2009-04-23 20:16 ` Jeff King
2009-04-23 20:45 ` Michael Witten
2009-04-23 21:31 ` David Abrahams
2009-04-24 0:31 ` Michael Witten
2009-04-24 14:18 ` Jeff King
2009-04-24 14:20 ` J. Bruce Fields
2009-04-24 17:28 ` David Abrahams
2009-04-24 18:15 ` Jeff King
2009-04-24 19:00 ` David Abrahams
2009-04-24 20:24 ` Jeff King
2009-04-24 21:06 ` David Abrahams
2009-04-24 22:45 ` Björn Steinbrink
2009-04-25 0:39 ` David Abrahams
2009-04-26 23:35 ` Björn Steinbrink
2009-04-24 14:11 ` Jeff King
2009-04-24 14:30 ` Michael Witten
2009-04-24 14:33 ` Michael Witten
2009-04-24 15:04 ` Jeff King
2009-04-24 15:18 ` Michael Witten
2009-04-24 17:38 ` J. Bruce Fields
2009-04-24 18:27 ` Jeff King
2009-04-24 18:35 ` J. Bruce Fields
[not found] ` <34BD51FF-0908-48A8-BBBC-E27B0EFB32E5@boostpro.com>
2009-04-24 18:52 ` J. Bruce Fields
2009-04-25 10:35 ` Felipe Contreras
2009-04-24 19:12 ` Michael Witten
2009-04-23 21:26 ` David Abrahams
2009-04-23 22:51 ` Johan Herland
2009-04-24 0:30 ` Michael Witten
2009-04-24 20:30 ` Johan Herland
2009-04-24 21:34 ` Daniel Barkalow
2009-04-24 21:38 ` Jeff King
2009-04-24 22:18 ` Michael Witten
2009-04-24 22:25 ` Michael Witten
2009-04-24 23:11 ` Daniel Barkalow
2009-04-24 23:14 ` Jeff King
2009-04-24 23:18 ` Michael Witten
2009-04-24 23:31 ` Michael Witten
2009-04-24 23:35 ` Jeff King
2009-04-25 0:19 ` Michael Witten
2009-04-25 10:18 ` Felipe Contreras
2009-04-24 23:26 ` Michael Witten
2009-04-25 18:55 ` Daniel Barkalow
2009-04-25 19:16 ` Michael Witten
2009-04-25 19:24 ` Felipe Contreras
2009-04-25 19:36 ` David Abrahams
2009-04-25 20:53 ` Felipe Contreras
2009-04-26 11:28 ` Björn Steinbrink
2009-04-26 13:55 ` David Abrahams
2009-04-26 17:56 ` Björn Steinbrink
2009-04-26 20:17 ` David Abrahams
2009-04-26 22:25 ` Björn Steinbrink
2009-04-27 1:41 ` David Abrahams
2009-04-27 16:30 ` David Abrahams
2009-04-27 16:52 ` Michael Witten
2009-04-26 16:36 ` Michael Witten
2009-04-26 18:12 ` Björn Steinbrink
2009-04-26 20:20 ` David Abrahams
2009-04-25 0:41 ` David Abrahams
2009-04-24 23:16 ` Björn Steinbrink
2009-04-25 0:01 ` Michael Witten
2009-04-25 0:48 ` David Abrahams
2009-04-26 22:42 ` Björn Steinbrink
2009-05-02 15:53 ` Björn Steinbrink
2009-05-02 18:36 ` Michael Witten
2009-05-02 21:11 ` Björn Steinbrink
2009-05-02 23:13 ` Michael Witten
2009-05-02 23:32 ` Björn Steinbrink
2009-05-03 1:10 ` Michael Witten
2009-05-03 1:48 ` Björn Steinbrink
2009-05-03 1:18 ` Mark Lodato
2009-05-03 1:26 ` Michael Witten
2009-04-24 23:21 ` Daniel Barkalow
2009-04-24 23:25 ` Jeff King
2009-04-26 23:41 ` Björn Steinbrink
2009-04-24 23:29 ` Michael Witten
2009-04-27 0:00 ` Björn Steinbrink [this message]
2009-04-25 0:19 ` David Abrahams
2009-04-25 0:26 ` Michael Witten
2009-04-25 0:35 ` Jeff King
2009-04-25 0:53 ` David Abrahams
2009-04-29 6:34 ` Jeff King
2009-04-29 13:27 ` David Abrahams
2009-04-29 14:05 ` Jeff King
2009-04-24 2:29 ` J. Bruce Fields
2009-04-24 2:34 ` Michael Witten
2009-04-24 4:06 ` David Abrahams
2009-04-24 14:10 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090427000007.GE12338@atjola.homenet \
--to=b.steinbrink@gmx.de \
--cc=barkalow@iabervon.org \
--cc=bfields@fieldses.org \
--cc=dave@boostpro.com \
--cc=git@vger.kernel.org \
--cc=johan@herland.net \
--cc=mfwitten@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).