From: "Wesley J. Landaker" <wjl@icecavern.net>
To: "Holger Weiß" <holger@zedat.fu-berlin.de>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Documentation: Fix description of archive "--prefix"
Date: Wed, 29 Apr 2009 20:33:01 -0600 [thread overview]
Message-ID: <200904292033.03899.wjl@icecavern.net> (raw)
In-Reply-To: <20090429154941.GB33221014@CIS.FU-Berlin.DE>
On Wednesday 29 April 2009 09:49:41 Holger Weiß wrote:
> * Holger Weiß <holger@zedat.fu-berlin.de> [2009-04-29 15:42]:
> > The description of the "--prefix" option suggested that a slash would
> > automatically be appended to the specified <prefix>, which is not the
> > case.
>
> Nonsense, it's telling the user that appending a slash to the <prefix>
> is mandatory. Scratch my patch.
I just tried not using a slash; it doesn't give an error or internally add
one, instead it makes a worthless archive:
$ git archive --prefix=noslash HEAD | tar tv | head
-rw-rw-r-- root/root 51 2009-04-28 01:46 noslash.gitattributes
-rw-rw-r-- root/root 2416 2009-04-28 01:46 noslash.gitignore
-rw-rw-r-- root/root 2519 2009-04-28 01:46 noslash.mailmap
-rw-rw-r-- root/root 18787 2009-04-28 01:46 noslashCOPYING
drwxrwxr-x root/root 0 2009-04-28 01:46 noslashDocumentation/
-rw-rw-r-- root/root 17 2009-04-28 01:46
noslashDocumentation/.gitattributes
-rw-rw-r-- root/root 91 2009-04-28 01:46
noslashDocumentation/.gitignore
-rw-rw-r-- root/root 4868 2009-04-28 01:46
noslashDocumentation/CodingGuidelines
-rw-rw-r-- root/root 9028 2009-04-28 01:46 noslashDocumentation/Makefile
-rw-rw-r-- root/root 1255 2009-04-28 01:46
noslashDocumentation/RelNotes-1.5.0.1.txt
Should this be fixed by automatically adding a slash if there wasn't one given?
I can't image anyone would want an archive made of mangled filenames like this,
so if we don't want that behavior, it seems like it should at least give an
error.
prev parent reply other threads:[~2009-04-30 2:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-29 13:42 [PATCH] Documentation: Fix description of archive "--prefix" Holger Weiß
2009-04-29 15:49 ` Holger Weiß
2009-04-30 2:33 ` Wesley J. Landaker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904292033.03899.wjl@icecavern.net \
--to=wjl@icecavern.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=holger@zedat.fu-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).