git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: Re: [JGIT PATCH v2 00/11] WindowCache rewrite... with tests
Date: Thu, 30 Apr 2009 01:46:30 +0200	[thread overview]
Message-ID: <200904300146.31062.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <1241031288-23437-1-git-send-email-spearce@spearce.org>

onsdag 29 april 2009 20:54:37 skrev "Shawn O. Pearce" <spearce@spearce.org>:
> 9-11 is the rewrite of WindowCache, with new unit tests to get higher
> levels of coverage in this section of the code.  Actually doing
> better is really hard, as we'd need to cause thread race conditions
> deep within critical sections.  The only way I can think to do that
> is to add injection points where we can insert "evil other thread"
> logic during the unit test, and rely on the JIT to compile them
> out in normal application usage.  Ick.  Its also quite fragile.

Testing *is* hard. No news here. There are various techniques for 
injecting code using AOP (AspjectJ) that may be useful for testing,
since we could inject failures that way without the overhead of
injection points in normal execution. 

-- robin

      parent reply	other threads:[~2009-04-29 23:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-29 18:54 [JGIT PATCH v2 00/11] WindowCache rewrite... with tests Shawn O. Pearce
2009-04-29 18:54 ` [JGIT PATCH 01/11] Fix more computation of integer average overflows Shawn O. Pearce
2009-04-29 18:54   ` [JGIT PATCH 02/11] Fix performance problem recently introduced to DeltaPackedObjectLoader Shawn O. Pearce
2009-04-29 18:54     ` [JGIT PATCH 03/11] Replace inefficient new String(String) constructor to silence FindBugs Shawn O. Pearce
2009-04-29 18:54       ` [JGIT PATCH 04/11] Replace inefficient new Long(long) " Shawn O. Pearce
2009-04-29 18:54         ` [JGIT PATCH 05/11] Change IndexPack to use ObjectIdSubclassMap instead of ObjectIdMap Shawn O. Pearce
2009-04-29 18:54           ` [JGIT PATCH 06/11] Use getCachedBytes in IndexPack to avoid an unnecessary copy Shawn O. Pearce
2009-04-29 18:54             ` [JGIT PATCH 07/11] Remove ObjectIdMap from the JGit library Shawn O. Pearce
2009-04-29 18:54               ` [JGIT PATCH 08/11] Don't use ByteWindows when checking pack file headers/footers Shawn O. Pearce
2009-04-29 18:54                 ` [JGIT PATCH v2 09/11] Rewrite WindowCache to be easier to follow and maintain Shawn O. Pearce
2009-04-29 18:54                   ` [JGIT PATCH 10/11] Add tests for WindowCache.reconfigure cases Shawn O. Pearce
2009-04-29 18:54                     ` [JGIT PATCH 11/11] Add tests to increase coverage of WindowCache Shawn O. Pearce
2009-04-29 23:46 ` Robin Rosenberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200904300146.31062.robin.rosenberg.lists@dewire.com \
    --to=robin.rosenberg.lists@dewire.com \
    --cc=git@vger.kernel.org \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).