From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: Re: [JGIT PATCH 1/2] Ensure that a PackFile instance stays invalid when overwritten
Date: Sun, 3 May 2009 10:05:57 +0200 [thread overview]
Message-ID: <200905031005.57638.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <1241296230-19342-1-git-send-email-spearce@spearce.org>
> @@ -339,6 +351,8 @@ synchronized boolean endWindowCache() {
>
> private void doOpen() throws IOException {
> try {
> + if (invalid)
> + throw new PackMismatchException("Pack checksum mismatch");
That /may/ be the case. We no longer know why the index failed to open. One way
is to save the reason, the other is not to be so d** sure and use a less specific
message.
-- robin
next prev parent reply other threads:[~2009-05-03 8:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-02 20:30 [JGIT PATCH 1/2] Ensure that a PackFile instance stays invalid when overwritten Shawn O. Pearce
2009-05-02 20:30 ` [JGIT PATCH 2/2] Correct Javadoc comment for TransportLocal about forking Shawn O. Pearce
2009-05-03 7:52 ` Robin Rosenberg
2009-05-04 13:57 ` Shawn O. Pearce
2009-05-03 8:05 ` Robin Rosenberg [this message]
2009-05-04 19:30 ` [JGIT PATCH v2 1/2] Ensure that a PackFile instance stays invalid when overwritten Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905031005.57638.robin.rosenberg.lists@dewire.com \
--to=robin.rosenberg.lists@dewire.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).