git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Stephen Boyd <bebarino@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/3] git-am.txt: Use date instead of time or timestamp
Date: Mon, 4 May 2009 03:25:23 -0400	[thread overview]
Message-ID: <20090504072523.GA12759@coredump.intra.peff.net> (raw)
In-Reply-To: <7vprep49h3.fsf@alter.siamese.dyndns.org>

On Mon, May 04, 2009 at 12:23:52AM -0700, Junio C Hamano wrote:

> >>  	commit creation as the committer date. This allows the
> >> -	user to lie about author timestamp by using the same
> >> +	user to lie about the author date by using the same
> >>  	timestamp as the committer date.
> >
> > But you leave the "timestamp" in the next context line?
> >
> > The other two patches in the series look fine to me, though.
> 
> Likewise.  Perhaps "using the same value as the committer date" sounds
> better?

Much better IMHO.

-Peff

  reply	other threads:[~2009-05-04  7:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-04  6:46 [PATCH 0/3] git-am documentation Stephen Boyd
2009-05-04  6:46 ` [PATCH 1/3] git-am.txt: add an 'a', say what 'it' is, simplify a sentence Stephen Boyd
2009-05-04  6:46   ` [PATCH 2/3] git-am.txt: Use date instead of time or timestamp Stephen Boyd
2009-05-04  6:46     ` [PATCH 3/3] git-am.txt: reword extra headers in message body Stephen Boyd
2009-05-04  7:15     ` [PATCH 2/3] git-am.txt: Use date instead of time or timestamp Jeff King
2009-05-04  7:23       ` Junio C Hamano
2009-05-04  7:25         ` Jeff King [this message]
2009-05-04 11:43   ` [PATCH 1/3] git-am.txt: add an 'a', say what 'it' is, simplify a sentence Michael J Gruber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090504072523.GA12759@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=bebarino@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).