From: "Shawn O. Pearce" <spearce@spearce.org>
To: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Cc: git@vger.kernel.org
Subject: Re: [JGIT PATCH 2/2] Correct Javadoc comment for TransportLocal about forking
Date: Mon, 4 May 2009 06:57:38 -0700 [thread overview]
Message-ID: <20090504135738.GR23604@spearce.org> (raw)
In-Reply-To: <200905030952.46075.robin.rosenberg.lists@dewire.com>
Robin Rosenberg <robin.rosenberg.lists@dewire.com> wrote:
> l?rdag 02 maj 2009 22:30:30 skrev "Shawn O. Pearce" <spearce@spearce.org>:
> > + * However, during {@link #openFetch()}, if the Transport has configured
> > + * {@link Transport#getOptionUploadPack()} to be anything other than
> > + * <code>"git-upload-pack"</code> or <code>"git upload-pack"</code>, this
> > + * implementation will fork and execute the external process, using an operating
> > + * system pipe to transfer data.
> > + * <p>
> > + * However, during {@link #openPush()}, if the Transport has configured
> > + * {@link Transport#getOptionReceivePack()} to be anything other than
> > + * <code>"git-receive-pack"</code> or <code>"git receive-pack"</code>, this
> > + * implementation will fork and execute the external process, using an operating
> > + * system pipe to transfer data.
> >
>
> I'll change the second However to Similarly. I think it reads better, even though I'm not a native English speaker.
Yea, you're right, it does read better that way. Thanks!
--
Shawn.
next prev parent reply other threads:[~2009-05-04 13:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-02 20:30 [JGIT PATCH 1/2] Ensure that a PackFile instance stays invalid when overwritten Shawn O. Pearce
2009-05-02 20:30 ` [JGIT PATCH 2/2] Correct Javadoc comment for TransportLocal about forking Shawn O. Pearce
2009-05-03 7:52 ` Robin Rosenberg
2009-05-04 13:57 ` Shawn O. Pearce [this message]
2009-05-03 8:05 ` [JGIT PATCH 1/2] Ensure that a PackFile instance stays invalid when overwritten Robin Rosenberg
2009-05-04 19:30 ` [JGIT PATCH v2 " Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090504135738.GR23604@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg.lists@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).