From: "Shawn O. Pearce" <spearce@spearce.org>
To: Nicolas Pitre <nico@cam.org>
Cc: Junio C Hamano <gitster@pobox.com>,
"Robin H. Johnson" <robbat2@gentoo.org>,
git@vger.kernel.org
Subject: Re: [PATCH] allow OFS_DELTA objects during a push
Date: Mon, 4 May 2009 15:11:29 -0700 [thread overview]
Message-ID: <20090504221129.GF23604@spearce.org> (raw)
In-Reply-To: <alpine.LFD.2.00.0905011616130.6741@xanadu.home>
Nicolas Pitre <nico@cam.org> wrote:
> The fetching of OFS_DELTA objects has been negotiated between both peers
> since git version 1.4.4. However, this was missing from the push side
> where every OFS_DELTA objects were always converted to REF_DELTA objects
> causing an increase in transferred data.
Folks, this may have broken git push for me.
I'm trying to debug it right now, but something in next between
46488d2 and 03e1664 has caused "git push" to not create a pack
file, sending the remote peer 0 objects, when really we should have
transmitted objects, e.g. in the case I just looked at, we should
have sent 11.
FWIW, I'm currently blaming this change as its the only thing to
touch builtin-send-pack.c in that commit range. :-)
/me goes off to debug this further...
> builtin-receive-pack.c | 22 +++++++++++++++-------
> builtin-send-pack.c | 8 +++++++-
> send-pack.h | 1 +
> 3 files changed, 23 insertions(+), 8 deletions(-)
--
Shawn.
next prev parent reply other threads:[~2009-05-04 22:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-15 18:27 Weird growth in packfile during initial push Robin H. Johnson
2009-04-15 19:51 ` Nicolas Pitre
2009-04-29 23:57 ` Junio C Hamano
2009-04-30 2:52 ` Nicolas Pitre
2009-05-01 6:17 ` Robin H. Johnson
2009-05-01 20:56 ` [PATCH] allow OFS_DELTA objects during a push Nicolas Pitre
2009-05-01 23:49 ` Junio C Hamano
2009-05-02 0:01 ` Compatibility between git.git and jgit Shawn O. Pearce
2009-05-02 1:14 ` A Large Angry SCM
2009-05-02 1:39 ` Nicolas Pitre
2009-05-02 1:59 ` Shawn O. Pearce
2009-05-02 16:56 ` Ealdwulf Wuffinga
2009-05-02 1:40 ` Michael Witten
2009-05-02 0:24 ` [PATCH] allow OFS_DELTA objects during a push Nicolas Pitre
2009-05-04 22:11 ` Shawn O. Pearce [this message]
2009-05-04 22:30 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090504221129.GF23604@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nico@cam.org \
--cc=robbat2@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).