From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Shawn O. Pearce" Subject: Re: [PATCH] allow OFS_DELTA objects during a push Date: Mon, 4 May 2009 15:11:29 -0700 Message-ID: <20090504221129.GF23604@spearce.org> References: <20090415182754.GF23644@curie-int> <7vy6tj109a.fsf@gitster.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Junio C Hamano , "Robin H. Johnson" , git@vger.kernel.org To: Nicolas Pitre X-From: git-owner@vger.kernel.org Tue May 05 00:11:42 2009 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1M16Nu-0007Xh-Qt for gcvg-git-2@gmane.org; Tue, 05 May 2009 00:11:39 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754074AbZEDWLa (ORCPT ); Mon, 4 May 2009 18:11:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752640AbZEDWLa (ORCPT ); Mon, 4 May 2009 18:11:30 -0400 Received: from george.spearce.org ([209.20.77.23]:50667 "EHLO george.spearce.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752104AbZEDWL3 (ORCPT ); Mon, 4 May 2009 18:11:29 -0400 Received: by george.spearce.org (Postfix, from userid 1001) id E368838195; Mon, 4 May 2009 22:11:29 +0000 (UTC) Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Nicolas Pitre wrote: > The fetching of OFS_DELTA objects has been negotiated between both peers > since git version 1.4.4. However, this was missing from the push side > where every OFS_DELTA objects were always converted to REF_DELTA objects > causing an increase in transferred data. Folks, this may have broken git push for me. I'm trying to debug it right now, but something in next between 46488d2 and 03e1664 has caused "git push" to not create a pack file, sending the remote peer 0 objects, when really we should have transmitted objects, e.g. in the case I just looked at, we should have sent 11. FWIW, I'm currently blaming this change as its the only thing to touch builtin-send-pack.c in that commit range. :-) /me goes off to debug this further... > builtin-receive-pack.c | 22 +++++++++++++++------- > builtin-send-pack.c | 8 +++++++- > send-pack.h | 1 + > 3 files changed, 23 insertions(+), 8 deletions(-) -- Shawn.