From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Shawn O. Pearce" Subject: Re: [PATCH] allow OFS_DELTA objects during a push Date: Mon, 4 May 2009 15:30:05 -0700 Message-ID: <20090504223005.GG23604@spearce.org> References: <20090415182754.GF23644@curie-int> <7vy6tj109a.fsf@gitster.siamese.dyndns.org> <20090504221129.GF23604@spearce.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Junio C Hamano , "Robin H. Johnson" , git@vger.kernel.org To: Nicolas Pitre X-From: git-owner@vger.kernel.org Tue May 05 00:30:26 2009 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1M16g5-0007PC-Ak for gcvg-git-2@gmane.org; Tue, 05 May 2009 00:30:25 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753012AbZEDWaH (ORCPT ); Mon, 4 May 2009 18:30:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752344AbZEDWaG (ORCPT ); Mon, 4 May 2009 18:30:06 -0400 Received: from george.spearce.org ([209.20.77.23]:32938 "EHLO george.spearce.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751765AbZEDWaF (ORCPT ); Mon, 4 May 2009 18:30:05 -0400 Received: by george.spearce.org (Postfix, from userid 1001) id 95E2F38195; Mon, 4 May 2009 22:30:05 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20090504221129.GF23604@spearce.org> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: "Shawn O. Pearce" wrote: > Nicolas Pitre wrote: > > The fetching of OFS_DELTA objects has been negotiated between both peers > > since git version 1.4.4. However, this was missing from the push side > > where every OFS_DELTA objects were always converted to REF_DELTA objects > > causing an increase in transferred data. > > Folks, this may have broken git push for me. > > I'm trying to debug it right now, but something in next between > 46488d2 and 03e1664 has caused "git push" to not create a pack > file, sending the remote peer 0 objects, when really we should have > transmitted objects, e.g. in the case I just looked at, we should > have sent 11. Uhm, never mind. Somehow my incremental build failed horribly; it compiled and created a git-push which worked "some of the time". Building again produced a working git-push. Scary stuff. Now I have to worry about the toolchain on this system. But I don't think there is a problem in git.git. -- Shawn.