From: "Shawn O. Pearce" <spearce@spearce.org>
To: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Cc: git@vger.kernel.org
Subject: [PATCH] Link to the Sun JVM bug mentioned in OffsetCache
Date: Wed, 6 May 2009 07:15:26 -0700 [thread overview]
Message-ID: <20090506141526.GA28164@spearce.org> (raw)
In-Reply-To: <20090429171659.GF23604@spearce.org>
This bug has now been published by Sun. We should link to the
database entry so we can find more detail later.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
"Shawn O. Pearce" <spearce@spearce.org> wrote:
> Robin Rosenberg <robin.rosenberg.lists@dewire.com> wrote:
> > > diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/OffsetCache.java b/org.spearce.jgit/src/org/spearce/jgit/lib/OffsetCache.java
> > > + private void gc() {
> > > + R r;
> > > + while ((r = (R) queue.poll()) != null) {
> > > + // Sun's Java 5 and 6 implementation have a bug where a Reference
> > > + // can be enqueued and dequeued twice on the same reference queue
> > > + // due to a race condition within ReferenceQueue.enqueue(Reference).
> >
> > Reference to the official Sun bug? Might help if someone wants to
> > implement a flag to avoid this (if necessary...)
>
> Actually, this is a new bug. I tried looking through BugParade
> but nobody has mentioned or discovered this before.
>
> I submitted a bug report yesterday, but they have yet to publish it.
And here it is.
.../src/org/spearce/jgit/lib/OffsetCache.java | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/OffsetCache.java b/org.spearce.jgit/src/org/spearce/jgit/lib/OffsetCache.java
index a1cd4be..b81c7e0 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/lib/OffsetCache.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/OffsetCache.java
@@ -414,6 +414,8 @@ private void gc() {
// can be enqueued and dequeued twice on the same reference queue
// due to a race condition within ReferenceQueue.enqueue(Reference).
//
+ // http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6837858
+ //
// We CANNOT permit a Reference to come through us twice, as it will
// skew the resource counters we maintain. Our canClear() check here
// provides a way to skip the redundant dequeues, if any.
--
1.6.3.rc4.206.g03e16
prev parent reply other threads:[~2009-05-06 14:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 2:26 [JGIT PATCH 1/2] Don't use ByteWindows when checking pack file headers/footers Shawn O. Pearce
2009-04-28 2:26 ` [JGIT RFC PATCH 2/2] Rewrite WindowCache to be easier to follow and maintain Shawn O. Pearce
2009-04-28 15:28 ` Shawn O. Pearce
2009-04-28 23:19 ` Robin Rosenberg
2009-04-28 23:30 ` Shawn O. Pearce
2009-04-29 17:16 ` Shawn O. Pearce
2009-04-30 7:34 ` Ferry Huberts (Pelagic)
2009-05-06 14:15 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090506141526.GA28164@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg.lists@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).