From: "Shawn O. Pearce" <spearce@spearce.org>
To: Alex Blewitt <alex.blewitt@gmail.com>
Cc: robin.rosenberg@dewire.com, git@vger.kernel.org
Subject: Re: [PATCH 2/2] Use NullProgressMonitor.INSTANCE and indent for loop
Date: Wed, 6 May 2009 13:41:25 -0700 [thread overview]
Message-ID: <20090506204125.GJ30527@spearce.org> (raw)
In-Reply-To: <1241642224-6914-2-git-send-email-alex.blewitt@gmail.com>
Alex Blewitt <alex.blewitt@gmail.com> wrote:
> ---
> .../src/org/spearce/jgit/lib/PackWriter.java | 25 ++++++++++---------
> 1 files changed, 13 insertions(+), 12 deletions(-)
Huh. These two should have been squashed together; see "git rebase
-i HEAD~2" and its "squash" subcommand.
It looks fine otherwise. I'll squash here when I apply. Just keep
it in mind for future reference.
--
Shawn.
next prev parent reply other threads:[~2009-05-06 20:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-06 20:37 [PATCH 1/2] Allow monitor/unintersting objects to be null Alex Blewitt
2009-05-06 20:37 ` [PATCH 2/2] Use NullProgressMonitor.INSTANCE and indent for loop Alex Blewitt
2009-05-06 20:41 ` Shawn O. Pearce [this message]
2009-05-06 20:48 ` Shawn O. Pearce
2009-05-06 20:50 ` Alex Blewitt
2009-05-06 20:54 ` Shawn O. Pearce
2009-05-06 21:10 ` [PATCH 1/2] Allow monitor/unintersting objects to be null Robin Rosenberg
2009-05-06 21:28 ` Alex Blewitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090506204125.GJ30527@spearce.org \
--to=spearce@spearce.org \
--cc=alex.blewitt@gmail.com \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).