git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: Mark Lodato <lodatom@gmail.com>
Cc: Michael J Gruber <git@drmicha.warpmail.net>,
	git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] git-svn: add --authors-prog option
Date: Sat, 9 May 2009 17:35:09 -0700	[thread overview]
Message-ID: <20090510003509.GA2000@dcvr.yhbt.net> (raw)
In-Reply-To: <ca433830905082048u6088a58ai16b1c979ef742f7@mail.gmail.com>

Mark Lodato <lodatom@gmail.com> wrote:
> On Fri, May 8, 2009 at 3:43 AM, Michael J Gruber
> <git@drmicha.warpmail.net> wrote:
> > Mark Lodato venit, vidit, dixit 08.05.2009 03:11:
> > Maybe we want a config key also, just like for the authors file.
> 
> Yes, this is a very good idea.  I will figure out how to do this.

It already works :)  Command-line options taken by git svn have always
been automatically converted to config keys.

> > The feature itself looks useful for large user databases. For smaller
> > ones one could just as well update the authors file before each fetch by
> > dumping the whole db in there (or even conditionally on git svn fetch
> > erroring out due to encountering an unknown name).
> 
> Right.  This feature will most likely be useful in corporate
> environments.  In my case, it is not possible to dump the entire user
> database to a file, so this patch is the only solution.  Another
> possible use case is where SVN usernames are standardized, e.g. "jdoe"
> -> "J Doe <jdoe@example.com>".  Also, using --authors-prog solves the
> problem of keeping the authors file up-to-date, if users are regularly
> added or deleted.

Thanks Mark.  Your patch looks good and I'll apply the next one after
the grammar fixes.  I've actually thought about implementing this myself
back when I (briefly) worked in a corporate environment, but never
got around to it.

Sorry for the late response and not following the mailing list more
closely these days.

-- 
Eric Wong

  reply	other threads:[~2009-05-10  0:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-08  1:11 [PATCH v2] git-svn: add --authors-prog option Mark Lodato
2009-05-08  7:43 ` Michael J Gruber
2009-05-09  3:48   ` Mark Lodato
2009-05-10  0:35     ` Eric Wong [this message]
2009-05-15  1:27       ` [PATCH v3] " Mark Lodato
2009-05-21  8:43         ` Eric Wong
2009-05-21 14:30           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090510003509.GA2000@dcvr.yhbt.net \
    --to=normalperson@yhbt.net \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=lodatom@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).