git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] http-push: fix missing "#ifdef USE_CURL_MULTI" around "is_running_queue"
@ 2009-05-10 16:44 Christian Couder
  2009-05-11 12:25 ` Tay Ray Chuan
  0 siblings, 1 reply; 3+ messages in thread
From: Christian Couder @ 2009-05-10 16:44 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git

As it is breaking the build when USE_CURL_MULTI is not defined.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 http-push.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

This patch applies to pu.

diff --git a/http-push.c b/http-push.c
index ef1a9f3..14f3996 100644
--- a/http-push.c
+++ b/http-push.c
@@ -2291,7 +2291,9 @@ int main(int argc, char **argv)
 		repo->url = rewritten_url;
 	}
 
+#ifdef USE_CURL_MULTI
 	is_running_queue = 0;
+#endif
 
 	/* Verify DAV compliance/lock support */
 	if (!locking_available()) {
-- 
1.6.3.rc1.112.g17e25

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] http-push: fix missing "#ifdef USE_CURL_MULTI" around  "is_running_queue"
  2009-05-10 16:44 [PATCH] http-push: fix missing "#ifdef USE_CURL_MULTI" around "is_running_queue" Christian Couder
@ 2009-05-11 12:25 ` Tay Ray Chuan
  2009-05-12  4:25   ` Christian Couder
  0 siblings, 1 reply; 3+ messages in thread
From: Tay Ray Chuan @ 2009-05-11 12:25 UTC (permalink / raw)
  To: Christian Couder; +Cc: Junio C Hamano, git

Hi,

On Mon, May 11, 2009 at 12:44 AM, Christian Couder
<chriscool@tuxfamily.org> wrote:
> As it is breaking the build when USE_CURL_MULTI is not defined.

thanks for catching this. By the way, how did you catch this? Are you
building without USE_CURL_MULTI defined?

-- 
Cheers,
Ray Chuan

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] http-push: fix missing "#ifdef USE_CURL_MULTI" around  "is_running_queue"
  2009-05-11 12:25 ` Tay Ray Chuan
@ 2009-05-12  4:25   ` Christian Couder
  0 siblings, 0 replies; 3+ messages in thread
From: Christian Couder @ 2009-05-12  4:25 UTC (permalink / raw)
  To: Tay Ray Chuan; +Cc: Junio C Hamano, git

Hi,

Le lundi 11 mai 2009, Tay Ray Chuan a écrit :
> Hi,
>
> On Mon, May 11, 2009 at 12:44 AM, Christian Couder
>
> <chriscool@tuxfamily.org> wrote:
> > As it is breaking the build when USE_CURL_MULTI is not defined.
>
> thanks for catching this. By the way, how did you catch this? Are you
> building without USE_CURL_MULTI defined?

My main development box still runs an old Kubuntu Feisty (7.04). It
has some libcurl3 packages version 7.15.5-1ubuntu2.

In "/usr/include/curl/curlver.h", I have:

#define LIBCURL_VERSION_NUM 0x070f05

and in "http.h" there is:

#if LIBCURL_VERSION_NUM >= 0x071000
#define USE_CURL_MULTI
#define DEFAULT_MAX_REQUESTS 5
#endif

so yes, I think USE_CURL_MULTI is not defined on my box and that's why
the build failed on it.

Regards,
Christian.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-05-12  4:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-10 16:44 [PATCH] http-push: fix missing "#ifdef USE_CURL_MULTI" around "is_running_queue" Christian Couder
2009-05-11 12:25 ` Tay Ray Chuan
2009-05-12  4:25   ` Christian Couder

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).