From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robin Rosenberg Subject: Re: [PATCH] Create $GIT_DIR/objects/pack if missing during renameAndOpenPack Date: Mon, 11 May 2009 00:59:50 +0200 Message-ID: <200905110059.50494.robin.rosenberg.lists@dewire.com> References: <693615.98383.qm@web27802.mail.ukl.yahoo.com> <20090510213046.GC30527@spearce.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Mark Struberg , git@vger.kernel.org To: "Shawn O. Pearce" X-From: git-owner@vger.kernel.org Mon May 11 01:01:35 2009 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1M3I1V-0006ko-Uq for gcvg-git-2@gmane.org; Mon, 11 May 2009 01:01:34 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753835AbZEJW77 convert rfc822-to-quoted-printable (ORCPT ); Sun, 10 May 2009 18:59:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753305AbZEJW77 (ORCPT ); Sun, 10 May 2009 18:59:59 -0400 Received: from mail.dewire.com ([83.140.172.130]:5030 "EHLO dewire.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752329AbZEJW76 convert rfc822-to-8bit (ORCPT ); Sun, 10 May 2009 18:59:58 -0400 Received: from localhost (localhost [127.0.0.1]) by dewire.com (Postfix) with ESMTP id 188B01444154; Mon, 11 May 2009 00:59:54 +0200 (CEST) X-Virus-Scanned: by amavisd-new at dewire.com Received: from dewire.com ([127.0.0.1]) by localhost (torino.dewire.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dH3qg8kIzYgO; Mon, 11 May 2009 00:59:52 +0200 (CEST) Received: from sleipner.localnet (unknown [10.9.0.7]) by dewire.com (Postfix) with ESMTP id AEF91144414D; Mon, 11 May 2009 00:59:52 +0200 (CEST) User-Agent: KMail/1.11.2 (Linux/2.6.28-11-generic; KDE/4.2.2; i686; ; ) In-Reply-To: <20090510213046.GC30527@spearce.org> Content-Disposition: inline Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: s=F6ndag 10 maj 2009 23:30:46 skrev "Shawn O. Pearce" : > diff --git a/org.spearce.jgit/src/org/spearce/jgit/transport/IndexPac= k.java b/org.spearce.jgit/src/org/spearce/jgit/transport/IndexPack.java > index b2bcbb7..1eb40d4 100644 > --- a/org.spearce.jgit/src/org/spearce/jgit/transport/IndexPack.java > +++ b/org.spearce.jgit/src/org/spearce/jgit/transport/IndexPack.java > @@ -1037,6 +1037,14 @@ public PackLock renameAndOpenPack(final String= lockMessage) > final File finalIdx =3D new File(packDir, "pack-" + name + ".idx")= ; > final PackLock keep =3D new PackLock(finalPack); > =20 > + if (!packDir.exists() && !packDir.mkdir() && !packDir.exists()) { Is there a lot to gain by this instead of just if (!packDir.mkdir() && = !packDir.exists()) ? -- robin