From: Jeff King <peff@peff.net>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Paul Mackerras <paulus@samba.org>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] gitk: use --textconv to generate diff text
Date: Mon, 11 May 2009 05:13:47 -0400 [thread overview]
Message-ID: <20090511091346.GA5685@coredump.intra.peff.net> (raw)
In-Reply-To: <4A07D160.9020709@viscovery.net>
On Mon, May 11, 2009 at 09:18:56AM +0200, Johannes Sixt wrote:
> For the most part gitk's focus is on showing history and changes in
> a human readable form. For this reason, it makes sense to generate
> the patch text in the diff view using --textconv so that textconv drivers
> are used if they are defined.
>
> gitk can also generate patches, but we do not use --textconv because
> such patches could not be applied.
>
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
As the original author of the textconv code, I am in favor of this. So
much so that I even posted basically the same patch before:
http://article.gmane.org/gmane.comp.version-control.git/102523
I had trouble finding much discussion in the archive, but I think it may
not have been taken because we were in release freeze (and textconv was
a brand new feature in the release at the time).
-Peff
next prev parent reply other threads:[~2009-05-11 9:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 7:18 [PATCH] gitk: use --textconv to generate diff text Johannes Sixt
2009-05-11 7:34 ` Johannes Sixt
2009-05-11 9:13 ` Jeff King [this message]
2009-05-11 21:20 ` Junio C Hamano
2009-05-11 21:59 ` Paul Mackerras
2009-05-11 22:38 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090511091346.GA5685@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).