From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: (revised) What's cooking in git.git (May 2009, #01; Sat, 09)
Date: Mon, 11 May 2009 05:35:50 -0400 [thread overview]
Message-ID: <20090511093550.GB5685@coredump.intra.peff.net> (raw)
In-Reply-To: <7vab5kwuoz.fsf@alter.siamese.dyndns.org>
On Sun, May 10, 2009 at 01:48:28PM -0700, Junio C Hamano wrote:
> * jk/maint-add-empty (Tue Apr 28 23:21:01 2009 -0400) 1 commit
> - add: don't complain when adding empty project root
>
> When you say "git add ." in an empty directory, you get "No path matches
> ''", instead of "No path matches '.'", and this "fixes" it by hiding the
> error and making the command silently succeed. Strictly speaking it
> introduces inconsistency, but I think an empty directory is so
> uninteresting special case that not signalling it as an error is Ok.
>
> Will merge to 'next'.
Actually, it is less invasive than that. It _already_ silently ignores
empty directories, like "mkdir foo && git add foo". And because of the
way we chdir to the project root, that is equivalent to "mkdir foo && cd
foo && git add .".
This just extends the behavior to the project root ("mkdir foo && cd foo
&& git init && git add ."). So arguably it is reducing inconsistency. :)
> * jk/no-no-no-empty-directory (Fri May 8 01:01:17 2009 -0400) 2 commits
> + parseopt: add OPT_NEGBIT
> + parseopt: add OPT_NEGBIT
>
> I somehow botched the commit log message of the top one; it is about
> fixing "ls-files --no-empty-directory".
Too bad it is not possible to rewind 'next'. ;)
> * jc/log-tz (Tue Mar 3 00:45:37 2009 -0800) 1 commit
> - Allow --date=local --date=other-format to work as expected
>
> The one I posted had a few corner-case bugs that was caught with the test
> suite; this one has them fixed. People did not like the UI so it is kept
> out of 'next'
This one has been sitting for a while. I was one of the complainers. If
there is interest, I can rework it according to our previous discussion
(but I'm beginning to wonder if anybody actually cares about this
patch).
-Peff
prev parent reply other threads:[~2009-05-11 9:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-10 6:53 What's cooking in git.git (May 2009, #01; Sat, 09) Junio C Hamano
2009-05-10 20:48 ` (revised) " Junio C Hamano
2009-05-11 9:35 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090511093550.GB5685@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).