git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Couder <chriscool@tuxfamily.org>
To: Tay Ray Chuan <rctay89@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] http-push: fix missing "#ifdef USE_CURL_MULTI" around  "is_running_queue"
Date: Tue, 12 May 2009 06:25:07 +0200	[thread overview]
Message-ID: <200905120625.07383.chriscool@tuxfamily.org> (raw)
In-Reply-To: <be6fef0d0905110525p7e7072d3y18f5c99b782c9bf9@mail.gmail.com>

Hi,

Le lundi 11 mai 2009, Tay Ray Chuan a écrit :
> Hi,
>
> On Mon, May 11, 2009 at 12:44 AM, Christian Couder
>
> <chriscool@tuxfamily.org> wrote:
> > As it is breaking the build when USE_CURL_MULTI is not defined.
>
> thanks for catching this. By the way, how did you catch this? Are you
> building without USE_CURL_MULTI defined?

My main development box still runs an old Kubuntu Feisty (7.04). It
has some libcurl3 packages version 7.15.5-1ubuntu2.

In "/usr/include/curl/curlver.h", I have:

#define LIBCURL_VERSION_NUM 0x070f05

and in "http.h" there is:

#if LIBCURL_VERSION_NUM >= 0x071000
#define USE_CURL_MULTI
#define DEFAULT_MAX_REQUESTS 5
#endif

so yes, I think USE_CURL_MULTI is not defined on my box and that's why
the build failed on it.

Regards,
Christian.

      reply	other threads:[~2009-05-12  4:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-10 16:44 [PATCH] http-push: fix missing "#ifdef USE_CURL_MULTI" around "is_running_queue" Christian Couder
2009-05-11 12:25 ` Tay Ray Chuan
2009-05-12  4:25   ` Christian Couder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200905120625.07383.chriscool@tuxfamily.org \
    --to=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=rctay89@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).