git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Karl Hasselström" <kha@treskal.com>
To: "David Kågedal" <davidk@lysator.liu.se>
Cc: catalin.marinas@gmail.com, git@vger.kernel.org
Subject: Re: [StGit PATCH v2] Add a --set-tree flag to stg push
Date: Tue, 19 May 2009 12:27:43 +0200	[thread overview]
Message-ID: <20090519102743.GA11135@diana.vm.bytemark.co.uk> (raw)
In-Reply-To: <20090519093506.22242.59442.stgit@krank>

On 2009-05-19 11:35:48 +0200, David Kågedal wrote:

> +    opt('--set-tree', action = 'store_true',
> +        short = 'Push the patch with the original tree', long = """
> +        Push the patches, but don't perform a merge. Instead, the
> +        resulting tree will be identical to the tree that the patch
> +        previously created. This can be useful when splitting a patch

Paragraph break after "created"?

> +        by first popping the patch and creating a new patch with some
> +        of the changes. Pushing the original patch with --set-tree
> +        will avoid conflicts and only the remaining changes will be in

The long description is fed to asciidoc, which will translate -- to an
en dash if I recall correctly. The long descriptions of other
commands' flags enclose flags in single quotes.

> +        the patch.
> +        """)

Unnecessary line break.

Apart from those nitpicks,

Acked-by: Karl Hasselström <kha@treskal.com>

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle

      reply	other threads:[~2009-05-19 10:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-18 14:50 [StGit PATCH] Add a --tree flag to stg push David Kågedal
2009-05-19  7:25 ` Karl Hasselström
2009-05-19  7:50   ` David Kågedal
2009-05-19  8:03     ` Karl Hasselström
2009-05-19  9:35   ` [StGit PATCH v2] Add a --set-tree " David Kågedal
2009-05-19 10:27     ` Karl Hasselström [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090519102743.GA11135@diana.vm.bytemark.co.uk \
    --to=kha@treskal.com \
    --cc=catalin.marinas@gmail.com \
    --cc=davidk@lysator.liu.se \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).