From: Mike Hommey <mh@glandium.org>
To: Tay Ray Chuan <rctay89@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 0/3] http*: refactor fetching code (v2)
Date: Wed, 20 May 2009 09:43:52 +0200 [thread overview]
Message-ID: <20090520074352.GC21455@glandium.org> (raw)
In-Reply-To: <20090518163025.58842505.rctay89@gmail.com>
On Mon, May 18, 2009 at 04:30:25PM +0800, Tay Ray Chuan wrote:
> This patch series applies on pu.
>
> The major differences between this series and the 11-patch long one
> (dated May 15, 2009) are:
>
> *check 'preq' pointer before using it (for fetching packs) [1]
> *moved free(url) before 'abort' label to stop -Wuninitialized warning
> (for fetching loose objects) [2]
> *use unlink_or_warn, after 691f1a2 ("replace direct calls to unlink
> (2) with unlink_or_warn")
>
> Junio: I've rebased the patch series on pu, hopefully this stops the
> attribute warnings for patch 3.
>
> Tay Ray Chuan (3):
> http*: add helper methods for fetching packs
> http*: add helper methods for fetching objects/info/packs
> http*: add helper methods for fetching objects (loose)
I do think these would be even better if they were integrated with
http://kerneltrap.org/mailarchive/git/2009/1/18/4757804.
Speaking of which, do we have a better http test suite now ? If we do, I
can try to (finally) finalize my work.
Mike
next prev parent reply other threads:[~2009-05-20 7:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 8:30 [PATCH 0/3] http*: refactor fetching code (v2) Tay Ray Chuan
2009-05-20 7:43 ` Mike Hommey [this message]
2009-05-20 10:21 ` Johannes Schindelin
2009-05-20 12:14 ` Tay Ray Chuan
2009-05-22 8:34 ` Clemens Buchacher
2009-05-20 12:10 ` Tay Ray Chuan
2009-05-20 14:03 ` Tony Finch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090520074352.GC21455@glandium.org \
--to=mh@glandium.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).