From: Jeff King <peff@peff.net>
To: Stephen Boyd <bebarino@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] t5500-fetch-pack: ignore output from git init
Date: Sun, 24 May 2009 12:48:26 -0400 [thread overview]
Message-ID: <20090524164826.GD22792@coredump.intra.peff.net> (raw)
In-Reply-To: <20090524164329.GC22792@coredump.intra.peff.net>
On Sun, May 24, 2009 at 12:43:30PM -0400, Jeff King wrote:
> > +++ b/t/t5500-fetch-pack.sh
> > @@ -97,7 +97,7 @@ pull_to_client () {
> > (
> > mkdir client &&
> > cd client &&
> > - git init 2>> log2.txt &&
> > + git init 2>> log2.txt > /dev/null &&
> > git config transfer.unpacklimit 0
> > )
>
> Why not:
>
> test_expect_success 'setup client repo' '
> mkdir client &&
> (cd client &&
> git init 2>>log2.txt &&
> git config transfer.unpacklimit 0
> )
> '
Actually, taking a closer look at the script, I think you could probably
ditch the '2>>log2.txt' bit entirely. The log file is never read and
appears to be completely for debugging. Putting the code into the test
harness means that output will respect --verbose properly, which means a
separate log is unnecessary.
-Peff
next prev parent reply other threads:[~2009-05-24 16:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-23 19:34 [PATCH] t5500-fetch-pack: ignore output from git init Stephen Boyd
2009-05-24 16:43 ` Jeff King
2009-05-24 16:48 ` Jeff King [this message]
2009-05-24 17:43 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090524164826.GD22792@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).