* [PATCH 07/18] Some cleanup in get_refs_via_curl()
@ 2009-05-24 14:19 Tay Ray Chuan
2009-05-24 20:43 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Tay Ray Chuan @ 2009-05-24 14:19 UTC (permalink / raw)
To: Git Mailing List; +Cc: Junio C Hamano, Johannes Schindelin, Mike Hommey
Signed-off-by: Mike Hommey <mh@glandium.org>
Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
---
transport.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/transport.c b/transport.c
index 89d846e..b7c1c39 100644
--- a/transport.c
+++ b/transport.c
@@ -519,6 +519,7 @@ static struct ref *get_refs_via_curl(struct transport *transport, int for_push)
free(ref);
}
+ free(refs_url);
return refs;
}
--
1.6.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 07/18] Some cleanup in get_refs_via_curl()
2009-05-24 14:19 [PATCH 07/18] Some cleanup in get_refs_via_curl() Tay Ray Chuan
@ 2009-05-24 20:43 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2009-05-24 20:43 UTC (permalink / raw)
To: Tay Ray Chuan
Cc: Git Mailing List, Junio C Hamano, Johannes Schindelin,
Mike Hommey
Tay Ray Chuan <rctay89@gmail.com> writes:
> Signed-off-by: Mike Hommey <mh@glandium.org>
> Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
The same comment as 06/18 on attribution apllies.
Be specific when you can without going to too verbose. In this case,
instead of wasting two meaningless words "Some cleanup", you can say:
Subject: transport.c::get_refs_via_curl(): do not leak refs_url
> transport.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/transport.c b/transport.c
> index 89d846e..b7c1c39 100644
> --- a/transport.c
> +++ b/transport.c
> @@ -519,6 +519,7 @@ static struct ref *get_refs_via_curl(struct transport *transport, int for_push)
> free(ref);
> }
>
> + free(refs_url);
> return refs;
> }
>
> --
> 1.6.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-05-24 21:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-24 14:19 [PATCH 07/18] Some cleanup in get_refs_via_curl() Tay Ray Chuan
2009-05-24 20:43 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).