From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/5] Speeding up "git status" and "git diff --cached"
Date: Mon, 25 May 2009 06:59:17 -0400 [thread overview]
Message-ID: <20090525105917.GA27070@coredump.intra.peff.net> (raw)
In-Reply-To: <1243106678-6343-1-git-send-email-gitster@pobox.com>
On Sat, May 23, 2009 at 12:24:33PM -0700, Junio C Hamano wrote:
> Here is a refined version of an earlier patch series to use cache-tree
> information to optimize comparison between the index with an existing
> commit.
I just read through the series, and it looks sane to me. My only concern
would be that we are forgetting some option that needs to disable the
optimization (in the same way that find-copies-harder) does, but I
couldn't think of one. And that is, after all, what cooking it in next
is for. :)
But I am not terribly familiar with the cache-trees corner of the code,
so take my endorsement with a grain of salt.
There is a minor typo in the subject of 2/5.
-Peff
prev parent reply other threads:[~2009-05-25 10:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-23 19:24 [PATCH 0/5] Speeding up "git status" and "git diff --cached" Junio C Hamano
2009-05-23 19:24 ` [PATCH 1/5] write-tree --ignore-cache-tree Junio C Hamano
2009-05-23 19:24 ` [PATCH 2/5] cache-tree.c::cache_tree_find(): simplify inernal API Junio C Hamano
2009-05-23 19:24 ` [PATCH 3/5] t4007: modernize the style Junio C Hamano
2009-05-23 19:24 ` [PATCH 4/5] Optimize "diff-index --cached" using cache-tree Junio C Hamano
2009-05-23 19:24 ` [PATCH 5/5] Avoid "diff-index --cached" optimization under --find-copies-harder Junio C Hamano
2009-05-25 10:59 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090525105917.GA27070@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).