git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: Matthias Andree <matthias.andree@gmx.de>
Cc: git@vger.kernel.org, users@subversion.tigris.org
Subject: Re: git-svn dcommits messages not in UTF-8 charset to mod_dav_svn?
Date: Thu, 28 May 2009 01:08:41 -0700	[thread overview]
Message-ID: <20090528080706.GA9239@dcvr.yhbt.net> (raw)
In-Reply-To: <op.uuljhmmg1e62zd@balu.cs.uni-paderborn.de>

Matthias Andree <matthias.andree@gmx.de> wrote:
> Greetings,
>
> I had tried to use git cvsimport and git svn to transfer a CVS repository 
> (I have access to it) to an SVN repository (where I don't have access to  
> the repo, so I cannot use cvs2svn or similar).
>
> The problem is that the CVS repo had non-UTF-8 commit log messages, and I 
> didn't bother to convert them to UTF-8. However, SVN insists on encoding  
> filenames and log messages in UTF-8.
>
> "git svn dcommit" (which uses the SVN Perl bindings under the hood)  
> happily committed such a non-UTF-8 message and br0ke the repo. The actual 
> reason is that the SVN server (https://...) is now wedged, as in:

> While mod_dav_svn arguably shouldn't accept b0rked messages, git-svn  
> shouldn't attempt to commit them either. It seems that the svn command  
> line utilities validate the message format by themselves, and apparently  
> the svn server module (likely mod_dav_svn - or are there others?) does 
> not.

This was partially fixed in commit
16fc08e2d86dad152194829d21bc55b2ef0c8fb1.  You just need to manually
specify the i18n.commitencoding in your .git/config

> So, could
> a) git-svn be modified to refuse dcommiting non-UTF-8 messages?

On the way is a patch that makes git-svn refuse to dcommit messages
that are malformed UTF-8 and tell the user about i18n.commitencoding.

Thanks for reminding me

-- 
Eric Wong

  reply	other threads:[~2009-05-28  8:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-27 16:16 git-svn dcommits messages not in UTF-8 charset to mod_dav_svn? Matthias Andree
2009-05-28  8:08 ` Eric Wong [this message]
2009-05-28  8:18   ` [PATCH] git-svn: refuse to dcommit non-UTF-8 messages Eric Wong
2009-05-29  7:09     ` Junio C Hamano
2009-05-29  7:56     ` Junio C Hamano
2009-05-29 14:11       ` Brandon Casey
2009-05-30  0:14         ` [PATCH] t9139 uses ancient, backwards-compatible iconv names Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090528080706.GA9239@dcvr.yhbt.net \
    --to=normalperson@yhbt.net \
    --cc=git@vger.kernel.org \
    --cc=matthias.andree@gmx.de \
    --cc=users@subversion.tigris.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).