From: Jeff King <peff@peff.net>
To: Brandon Casey <casey@nrlssc.navy.mil>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Brandon Casey <drafnel@gmail.com>
Subject: Re: [PATCH 4/4] Makefile: introduce SANE_TOOL_PATH for prepending required elements to PATH
Date: Thu, 28 May 2009 15:13:43 -0400 [thread overview]
Message-ID: <20090528191342.GF13499@coredump.intra.peff.net> (raw)
In-Reply-To: <8D9Pn2N3FZLQcyxrPABrGxTLa3Dlq25WDqK5xSJyY6cvQv4mphIUXvRu59EA7ewVS-vbi5IZUc4@cipher.nrlssc.navy.mil>
On Wed, May 27, 2009 at 09:17:08PM -0500, Brandon Casey wrote:
> Some platforms (like SunOS and family) have kept their common binaries at
> some historical moment in time, and introduced new binaries with modern
> features in a special location like /usr/xpg4/bin or /usr/ucb. Some of the
> features provided by these modern binaries are expected and required by git.
> If the featureful binaries are not in the users path, then git could end up
> using the less featureful binary and fail.
>
> So provide a mechanism to prepend elements to the users PATH at runtime so
> the modern binaries will be found.
My concern with this is that the PATH bleeds over into things we execute
on behalf of the user, like GIT_EDITOR or snippets in git-filter-branch.
So we can end up surprising users that way.
On the other hand, I don't know how big a problem that is in practice. I
feel like any sane Solaris user is going to have xpg4 in their PATH
these days.
-Peff
next prev parent reply other threads:[~2009-05-28 19:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-28 2:17 [PATCH 1/4] Makefile: use /usr/ucb/install on SunOS platforms rather than ginstall Brandon Casey
2009-05-28 2:17 ` [PATCH 2/4] Makefile: add NEEDS_RESOLV to optionally add -lresolv to compile arguments Brandon Casey
2009-05-28 2:17 ` [PATCH 3/4] Makefile: add section for SunOS 5.7 Brandon Casey
2009-05-28 2:17 ` [PATCH 4/4] Makefile: introduce SANE_TOOL_PATH for prepending required elements to PATH Brandon Casey
2009-05-28 19:13 ` Jeff King [this message]
2009-05-29 5:13 ` Junio C Hamano
2009-05-28 19:10 ` [PATCH 2/4] Makefile: add NEEDS_RESOLV to optionally add -lresolv to compile arguments Jeff King
2009-05-28 19:32 ` Brandon Casey
2009-05-28 19:35 ` Jeff King
2009-05-28 18:57 ` [PATCH 1/4] Makefile: use /usr/ucb/install on SunOS platforms rather than ginstall Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090528191342.GF13499@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=casey@nrlssc.navy.mil \
--cc=drafnel@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).