From: Jeff King <peff@peff.net>
To: Brandon Casey <casey@nrlssc.navy.mil>
Cc: git@vger.kernel.org, Brandon Casey <drafnel@gmail.com>
Subject: Re: [PATCH 2/4] Makefile: add NEEDS_RESOLV to optionally add -lresolv to compile arguments
Date: Thu, 28 May 2009 15:35:37 -0400 [thread overview]
Message-ID: <20090528193537.GA14324@coredump.intra.peff.net> (raw)
In-Reply-To: <vVyKoW1VAw2ieNPkJ-SGMNqgFzp_toRpDdk-ZeAp3qzdczSzN4yckg@cipher.nrlssc.navy.mil>
On Thu, May 28, 2009 at 02:32:20PM -0500, Brandon Casey wrote:
> >> This library is required on Solaris since hstrerror resides in libresolv.
> >> Additionally, on Solaris 7, inet_ntop and inet_pton reside there too.
> >
> > Patch works for me on Solaris 8, though it is largely a non-issue:
> > hstrerror is only used at all if NO_IPV6 is set, and I don't set that
> > for my build.
>
> Ah, in that case I guess NEED_RESOLV should only go in the 5.7 specific
> configuration section.
Well, not exactly. Getting rid of NO_HSTRERROR and then compiling with
NO_IPV6 still requires NEED_RESOLV. It's just that NO_HSTRERROR isn't
even useful unless NO_IPV6 is defined.
-Peff
next prev parent reply other threads:[~2009-05-28 19:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-28 2:17 [PATCH 1/4] Makefile: use /usr/ucb/install on SunOS platforms rather than ginstall Brandon Casey
2009-05-28 2:17 ` [PATCH 2/4] Makefile: add NEEDS_RESOLV to optionally add -lresolv to compile arguments Brandon Casey
2009-05-28 2:17 ` [PATCH 3/4] Makefile: add section for SunOS 5.7 Brandon Casey
2009-05-28 2:17 ` [PATCH 4/4] Makefile: introduce SANE_TOOL_PATH for prepending required elements to PATH Brandon Casey
2009-05-28 19:13 ` Jeff King
2009-05-29 5:13 ` Junio C Hamano
2009-05-28 19:10 ` [PATCH 2/4] Makefile: add NEEDS_RESOLV to optionally add -lresolv to compile arguments Jeff King
2009-05-28 19:32 ` Brandon Casey
2009-05-28 19:35 ` Jeff King [this message]
2009-05-28 18:57 ` [PATCH 1/4] Makefile: use /usr/ucb/install on SunOS platforms rather than ginstall Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090528193537.GA14324@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=casey@nrlssc.navy.mil \
--cc=drafnel@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).