From: Christian Couder <chriscool@tuxfamily.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: [PATCH] bisect: use "clear_commit_marks" after checking ancestors
Date: Thu, 28 May 2009 23:24:43 +0200 [thread overview]
Message-ID: <20090528212444.4034.68662.chriscool@tuxfamily.org> (raw)
instead of "unparse_commit", as it is enough to just clear flags.
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
bisect.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
As the patch series where "unparse_commit" is added and
used is already in "next". Here is a patch to use
"clear_commit_marks" instead. The patch that adds
"unparse_commit" can be reverted from "next" after this
one.
diff --git a/bisect.c b/bisect.c
index c43c120..18f9fa4 100644
--- a/bisect.c
+++ b/bisect.c
@@ -771,7 +771,7 @@ static int check_ancestors(const char *prefix)
/* Clean up objects used, as they will be reused. */
for (i = 0; i < pending_copy.nr; i++) {
struct object *o = pending_copy.objects[i].item;
- unparse_commit((struct commit *)o);
+ clear_commit_marks((struct commit *)o, ALL_REV_FLAGS);
}
return res;
--
1.6.3.GIT
reply other threads:[~2009-05-28 21:30 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090528212444.4034.68662.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).