From: "Shawn O. Pearce" <spearce@spearce.org>
To: SZEDER G??bor <szeder@ira.uka.de>
Cc: Ted Pavlic <ted@tedpavlic.com>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH] bash: remove always true if statement from __git_ps1()
Date: Fri, 29 May 2009 08:03:19 -0700 [thread overview]
Message-ID: <20090529150319.GC30527@spearce.org> (raw)
In-Reply-To: <1243598436-2207-1-git-send-email-szeder@ira.uka.de>
SZEDER G??bor <szeder@ira.uka.de> wrote:
> The recent commits 8763dbb1 (completion: fix PS1 display during a
> merge on detached HEAD, 2009-05-16), ff790b6a (completion: simplify
> "current branch" in __git_ps1(), 2009-05-10), and d7107ca6
> (completion: fix PS1 display during an AM on detached HEAD,
> 2009-05-26) ensure that the branch name in __git_ps1() is always set
> to something sensible. Therefore, the condition for checking the
> non-empty branch name is always fulfilled, and can be removed.
>
> Signed-off-by: SZEDER G??bor <szeder@ira.uka.de>
> ---
>
> The patch is the same, but the commit message is different, because
> Junio's d7107ca6 has fixed the issue.
>
> contrib/completion/git-completion.bash | 10 ++++------
> 1 files changed, 4 insertions(+), 6 deletions(-)
Yay, code reduction is good. :-)
Trivially-Acked-by: Shawn O. Pearce <spearce@spearce.org>
--
Shawn.
prev parent reply other threads:[~2009-05-29 15:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-28 16:17 [PATCH] bash: display git prompt in case of merge conflict during rebase SZEDER Gábor
2009-05-28 17:01 ` SZEDER Gábor
2009-05-29 12:00 ` [PATCH] bash: remove always true if statement from __git_ps1() SZEDER Gábor
2009-05-29 15:03 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090529150319.GC30527@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder@ira.uka.de \
--cc=ted@tedpavlic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).