From: Ben Jackson <ben@ben.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, normalperson@yhbt.net, ben@ben.com
Subject: Re: [PATCH 2/2] Add 'git svn reset' to unwind 'git svn fetch'
Date: Mon, 1 Jun 2009 10:49:44 -0700 [thread overview]
Message-ID: <20090601174943.GA80846@kronos.home.ben.com> (raw)
In-Reply-To: <1243732627-82282-2-git-send-email-ben@ben.com>
On Sat, May 30, 2009 at 06:17:07PM -0700, Ben Jackson wrote:
> Add a command to unwind the effects of fetch by moving the rev_map
> and refs/remotes/git-svn back to an old SVN revision.
I just realized this morning that I didn't do any special handling for
bad revision input. I will submit a revised patch. In the mean time
I would still like feedback on the concept and the docs.
Known issues:
1. Garbage revision input is accepted and prints several internal errors
before bombing out. The repo is not harmed, though.
2. Huge revision numbers cause git-svn to spin for quite a while because
I used the pre-existing find_rev_before which is a linear search.
3. Without --parent it should probably fail for a nonexistent rev rather
than automatically find_rev_before..
--
Ben Jackson AD7GD
<ben@ben.com>
http://www.ben.com/
next prev parent reply other threads:[~2009-06-01 17:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-31 1:17 [PATCH 1/2] Add 'git svn help [cmd]' which works outside a repo Ben Jackson
2009-05-31 1:17 ` [PATCH 2/2] Add 'git svn reset' to unwind 'git svn fetch' Ben Jackson
2009-06-01 17:49 ` Ben Jackson [this message]
2009-06-04 0:24 ` Eric Wong
2009-06-04 2:48 ` [PATCH 1/2] Add 'git svn help [cmd]' which works outside a repo Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090601174943.GA80846@kronos.home.ben.com \
--to=ben@ben.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).