git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Couder <chriscool@tuxfamily.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Sam Vilain <sam@vilain.net>,
	"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 0/4] make it possible to skip away from broken commits
Date: Wed, 3 Jun 2009 08:29:48 +0200	[thread overview]
Message-ID: <200906030829.48470.chriscool@tuxfamily.org> (raw)
In-Reply-To: <7vmy8qe4ru.fsf@alter.siamese.dyndns.org>

Le Tuesday 02 June 2009, Junio C Hamano a écrit :
> Christian Couder <chriscool@tuxfamily.org> writes:
> > This patch series adds a "--ratio=x/y" option to "git bisect skip" so
> > that it is possible to skip away from an area were the commits cannot
> > be tested.
> >
> > Note that in this series "--ratio=4" means the same as "--ratio=1/4".
> > But I am not sure if this shortcut is worth it.
>
> Actually my gut feeling is that a tweakable knob itself is worth it,
> because the user can never tell what the right value should be.

You mean a boolean configuration variable like "bisect.skip_away" or 
a "--skip_away" switch to "git bisect start" or both?

> Especially without any documentation updates that explains what this
> ratio refers to ;-), but I suspect, unless the user is very familiar with
> how the revision graph bisection internally works, such an explanation
> would not help him find a skip ratio that is closer to the optimum than a
> random guess.  Why not use a constant ratio (or perhaps a pair of
> alternating ratios) on "bisect skip" without any new options?

Ok, I will have a look at that too.

Thanks,
Christian.

      parent reply	other threads:[~2009-06-03  6:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-02 20:16 [PATCH 0/4] make it possible to skip away from broken commits Christian Couder
2009-06-02 20:16 ` [PATCH 1/4] bisect: add parameters to "filter_skipped" Christian Couder
2009-06-02 20:16 ` [PATCH 2/4] bisect: use the skip ratio to choose a commit away from a skipped commit Christian Couder
2009-06-02 20:16 ` [PATCH 3/4] bisect: add "--ratio=<ratio>" option to "git bisect skip" Christian Couder
2009-06-02 20:16 ` [PATCH 4/4] t6030: add test case for "git bisect skip --ratio=x/y" Christian Couder
2009-06-02 20:53 ` [PATCH 0/4] make it possible to skip away from broken commits Junio C Hamano
2009-06-03  3:14   ` H. Peter Anvin
2009-06-03  6:32     ` Christian Couder
2009-06-03  7:10     ` Junio C Hamano
2009-06-03  6:29   ` Christian Couder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906030829.48470.chriscool@tuxfamily.org \
    --to=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=hpa@zytor.com \
    --cc=mingo@elte.hu \
    --cc=sam@vilain.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).